Comments (3)
@varon @daerogami There is practically nothing left of this issue, and it should probably be closed. Smaller, more quantifiable issues can be opened for any warnings still present.
from opentk.
(Originally accidentally posted in a pull request related to this) In addition to normal warnings I would like to ask if going over the code and look at warnings given from utilities like ReSharper could be included in this. Perhaps including warnings on code style standards?
from opentk.
Static analysis is really useful, but it takes some effort to distinguish useful warnings from fluff. When I last tried this on OpenTK, I got several thousands of warnings but only a few dozen of those were actual code quality issues.
For example, in the attached screenshot it is suggested to move Lindgren.Network/Encryption
to Lindgren/Network/Encryption
and rename private variables from m_*
to _*
. These are cosmetic issues. Fixing these would make other forks more difficult to merge and potentially introduce new bugs, for a very modest improvement in code quality.
I would happily accept PRs that fix potential issues revealed through static analysis, but I am quite skeptical about the value of fixing cosmetic issues in private code.
from opentk.
Related Issues (20)
- MathF or Math? (Matrix4.cs) HOT 2
- No TargetFrameworks set in Nuget Package HOT 4
- Unable to load openal library when built with nativeaot targeting android HOT 3
- [PAL2] PAL 2 Todo list
- Add support for OpenGL ES 3.2 HOT 4
- OpenTK.OpenAL 4.8.1 not present on nuget.org HOT 3
- replace all "ref" statement for "in" instead HOT 4
- Linux / .NET8 doesn't find libglfw HOT 2
- How to continuously record audio using OpenAL? HOT 7
- PAL 2 MacOS TODO list
- PAL 2 X11/Linux TODO list
- opentk is missing NuGet package README file
- Change of basis matrix functions
- Could you provide a dot dash line interface? eg glLineStipple() HOT 2
- Update to GLFW 3.4
- Possible ANGLE setting for glfw 3.4?
- Fix documentation for OpenAL FilterTypes
- ALSourcei.SourceState missing HOT 1
- Inclusion of sperical interpolation to math lib
- `MathHelper.Lerp` should not clamp `t` argument
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentk.