Comments (8)
That's great, thanks! I'll gladly accept a pull request if you can submit it according to the contributors' guide!
I think the help text you already added to the .service
file is sufficient documentation. There isn't really anywhere else to put it. I'm not sure about password
- even with a read-only account there's still a risk it could expose access to other parts of the svn tree which were not intended to be generally accessible. But I'm open to arguments either way.
from obs-service-tar_scm.
To be honest, I never used git before (and never wrote a script in python either).
And yes I read the contributor's guide before, it states
If you are unable to provide a fix via a pull request, please submit an issue. ;-)
Since I'm more familiar with diff and patch I attached a udiff (where I know what I do). Would you accept this as well?
Regarding the password setting option: it is about freedom of choice. The user can decide what suits better to him: doing something as root on obs server or putting the password for a ro account into a service file. If you are interested I'd add and test this option as well.
from obs-service-tar_scm.
To be honest, I never used git before (and never wrote a script in python either).
Ah well, so isn't this the perfect excuse to start learning git? ;-) It's not too hard, and it's a tremendously useful (and important) tool to have under your belt, since the vast majority of the development world use git these days, and github is almost as popular. Plus it's fun ;-)
Also there are plenty of great tutorials available to guide you through, e.g.
- https://www.thinkful.com/learn/github-pull-request-tutorial/
- https://youtu.be/oFYyTZwMyAg
- http://stackoverflow.com/questions/14680711/how-to-do-a-github-pull-request
- https://yangsu.github.io/pull-request-tutorial/
- https://git-scm.com/
But if you really can't or don't want to, maybe I can do it, but it's unlikely to happen any time soon.
from obs-service-tar_scm.
I could do that for you, as I'm dealing with http proxy support. But right now I need someone to look over my code and find out what is wrong, since I can run the "make check" tests locally, but Travis CI bombs out with a syntax error(?)
from obs-service-tar_scm.
Just created #342 that allow authentication for multiple SCM including svn.
Please let me know if it fits your needs ?
from obs-service-tar_scm.
Just created #342 that allow authentication for multiple SCM including svn.
Please let me know if it fits your needs ?
That looks fine to me. One question though: since there will be one keyring for everyone, shouldn't there be an admin GUI to deal with it?
from obs-service-tar_scm.
Hi @doccaz , the drawback here is that you'll need an ssh access to the machine and the perms to sudo to obsservicerun to create/update the keyring. I guess it would be pretty hard to implement a GUI that will distinguished the OBS users running the service.
Changes should be done in the https://github.com/openSUSE/open-build-service repo
from obs-service-tar_scm.
Hi @doccaz , the drawback here is that you'll need an ssh access to the machine and the perms to sudo to obsservicerun to create/update the keyring. I guess it would be pretty hard to implement a GUI that will distinguished the OBS users running the service.
Changes should be done in the https://github.com/openSUSE/open-build-service repo
You're right. However, wouldn't the password be exposed in the service for everyone? Maybe it'd be a good idea to have a password attribute for the project/package?
from obs-service-tar_scm.
Related Issues (20)
- KeyError: 'object_kind' in TarSCM/tasks.py on Leap 15.4 HOT 2
- Support different scm repository name in case of forks HOT 1
- obs_scm seems to broken on CentOS_8 HOT 7
- make included .git reproducible
- Service broken if .lock file left over by previous versions HOT 2
- Causes "unresolvable" error for Fedora 34+ HOT 3
- 'exclude' behaviour change in obs_scm HOT 1
- test fail on Fedora 37 HOT 4
- .obscpio file format hex code means? HOT 1
- obs_gbp: dpkg-scansources also finds any .dsc in the source clone
- Use numeric owner and group to avoid privacy leaking HOT 1
- Error with Python 3.12 due to deprecated and removed 'readfp' usage HOT 2
- Error in Fedora_Rawhide: AttributeError: 'RawConfigParser' object has no attribute 'readfp'. Did you mean: 'read'? HOT 1
- project top level has a directory with the same name as the branch, the pull will fail.
- Chooses the wrong tag in case of several tags being present HOT 1
- @TAG_OFFSET@ not working without a tag in versionformat
- Please provide better documentation
- We should default to main branches too HOT 1
- package-meta HOT 1
- Enable changesgenerate to create a new top level entry per git tag encountered
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from obs-service-tar_scm.