client.shell returns inconsistent output about adbkit HOT 7 CLOSED

I agree that the documentation is wrong, we'll need to fix that. But I don't see how you would get either a buffer or a stream randomly... I just tried the example code as-is and it worked fine. Can you share some more details about your investigation?

from adbkit.

Sure, I'm glad to help.

I call this code as a part of my device resilience subsystem:

client.shell(serial, 'ifconfig wlan0')
    .then(adb.util.readAll)
    .then(function commandResult(result) {
        return result.toString()
    });

...and, as you've already suggested, it produces the error in a random way :(
I have no idea, maybe it's the command, maybe it's the device the thing is I randomly get a Buffer instead of a Stream.

I totally forgot to add my env data:
Version of adbkit: 2.3.1
Node: 0.10.40
System: Windows Server 2012 R2
Device: Nexus 7, Android 5.1.1

Other than that, GREAT JOB, this module saves lives ;)

from adbkit.

Might be worth trying with Node 0.12 or 4.x. We haven't tested 0.10 in a long time and there were some stream-related changes in 0.12 that I remember having to fix (although it could have been just that our code was bad). Also we've never tested anything on Windows... :)

Are you sure it really returns a buffer and not something else? Could you do .then(function(really) { console.log('really?', really, typeof really) }) instead of readAll?

from adbkit.

Also, https://github.com/petkaantonov/bluebird/blob/master/API.md#promiselongstacktraces---void may or may not help a little in providing a more useful stack trace.

from adbkit.

I will update my node.js to 0.12.7, and I will check the Buffer hipothesis :)
Thanks!

from adbkit.

So after one day of scrutinizing the code, and running test on real hardware there and back again, it seems that there was an issue with the old version of node.js.
The 0.12.7 version appears to be as stable as a solid rock.
Thanks for all the help :)

from adbkit.

It took me awhile to figure out how to use readAll() with Promises so I'm positing it here to help others:

const stream = await adbClient.shell( config.udid, "ime list -s" )
const result = await adb.util.readAll( stream );
console.log( result.toString() ); // => com.sec.android.inputmethod/.SamsungKeypad

from adbkit.