Copious warnings building Juce classes... about libopenshot-audio HOT 5 CLOSED

Actually, here's an updated version of the output file, with the /home/ferd... components of the path edited out. That makes it narrower, and slightly more readable.

libopenshot-audio.out.txt

(Note: There's also my unrelated PR #19, filed 2.5 months ago. It fixes an issue with one of the header files generated by libopenshot-audio. The header file as packaged causes OpenShot/libopenshot#42, where libopenshot fails to compile with that header. We're still patching for that on the downstream end, as you can see in the build output attached.)

from libopenshot-audio.

@ferdnyc - Does this explain audio popping or is that a separate issue? I've noticed while v2.4.3 is turning out to be a much more stable release the audio popping issues remain for many users.

from libopenshot-audio.

Honestly, I have no idea. It may explain anything or nothing. It depends whether the code is really performing unsafe memory operations. gcc can flag operations that appear unsafe, but it can't determine whether there's actually anything to be concerned about.

Using C-style mem*() functions on C++ classes is considered bad form because if those classes aren't trivial structures, they may require more complex, recursive operations to move or duplicate their contents — like Python's deepcopy(). But if the code is certain that all of the structures are shallow, then it's fine the way it is and the warnings are nothing more than paranoia.

from libopenshot-audio.

For the most part, these warnings are cleared up by JUCE 5. Closing!

from libopenshot-audio.

Nice!

from libopenshot-audio.