Cleanup script "Make clean" is not removing /opt/dev-scripts directory about dev-scripts HOT 3 CLOSED

IMHO this isn't a bug, we deliberately don't remove $WORKING_DIR or you'd have to download multi-gigabyte qcow2 files every single test iteration.

Sounds like you changed users after the initial run, so some manual cleanup seems acceptable in that case, if the alternative is causing every other user to spend more time/bandwidth during testing?

from dev-scripts.

I guess the alternative in common.sh is to change this:

if [ ! -d "$WORKING_DIR" ]; then
  echo "Creating Working Dir"
  sudo mkdir "$WORKING_DIR"
  sudo chown "${USER}:${USER}" "$WORKING_DIR"
  chmod 755 "$WORKING_DIR"
fi

to

if [ ! -d "$WORKING_DIR" ]; then
  echo "Creating Working Dir"
  sudo mkdir "$WORKING_DIR"
fi
sudo chown -R "${USER}:${USER}" "$WORKING_DIR"
chmod 755 "$WORKING_DIR"

from dev-scripts.

I'm going to close this as I think the recursive chown is likely to break things where we've got existing files owned e.g by root and not $USER. In the case where you choose to switch to a different non-root user I think it's acceptable to do some manual cleanup.

from dev-scripts.