JUnit RocketTest.testCopyFrom() NPE during rocket copy about openrocket HOT 3 CLOSED

Looks like the cause is that the code to set the motor configuration is commented out for the test rockets ( openrocket.util.TestRockets.makeIsoHaisu() and openrocket.util.TestRockets.makeBigBlue() ), copy expects motor configuration to be there. BodyTube.copyWithOriginalID() expects the motor configuration to be non-null at line 435.

Fix is either to modify the motor configuration code for the test rockets to work (if I uncomment it doesn't work), or to modify BodyTube copy to accept a null motor configuration. Do all body tubes have a motor configuration?

from openrocket.

Actually, it's more likely a bug in the BodyTube constructors. There are three. The no argument constructor initializes the configuration. However, the two others do not initialize it. These are only used by the test rockets.

I'll fix this.

from openrocket.

Fixed BodyTube constructors.

from openrocket.