Code Monkey home page Code Monkey logo

Comments (6)

phrohdoh avatar phrohdoh commented on May 18, 2024

In fact SLNs do not have direct access to environment variables so project paths must be hardcoded (or changed locally only to be undone before committing/pushing, which is a PITA and extra work).

from openramodsdk.

pchote avatar pchote commented on May 18, 2024

What are your expectations here, and what is the goal of this issue?

Like you say, it is not technically feasible to support per-user engine paths, and I don't understand the motivation for wanting these. The ModSDK is designed around the idea of every mod being self contained, and having an external engine working directory which is shared across multiple projects (which is the only use case I can think for this?) explicitly conflicts with that design, even if it were technically possible.

Would the best fix here be to write some documentation explaining this philosophy?

The Mod SDK itself is the tool that provides the exact same file structure, and the configuration flag for changing that is prefixed with

OpenRAModSDK/mod.config

Lines 69 to 73 in 4afe9d1

##############################################################################
# Advanced Configuration
#
# Most projects will not need to modify these
##############################################################################

from openramodsdk.

phrohdoh avatar phrohdoh commented on May 18, 2024

If supporting external engines is explicitly a non-goal then what do users gain from the ENGINE_DIRECTORY being customizable?

The mod sdk is not something I can invoke that will stub files, change dependency versions, package installers. It is currently a collection of scripts (shell, makefile, powershell, etc). I've discussed a tool to unify all of this on IRC a couple of times (as I truly believe that is a better approach than users manually invoking scripts [which lends them to invoking scripts they shouldn't be touching]).

from openramodsdk.

phrohdoh avatar phrohdoh commented on May 18, 2024

A "fix" for this could be adding a note above the ENGINE_DIRECTORY setting stating that external-to-the-project paths are not supported.

from openramodsdk.

pchote avatar pchote commented on May 18, 2024

If supporting external engines is explicitly a non-goal then what do users gain from the ENGINE_DIRECTORY being customizable?

Not much, but that was never the goal. The variable is there for documentation, so that the user can see and understand what is going on behind the scenes, and to avoid hardcoding magic paths in 42 (and counting) other places.

from openramodsdk.

pchote avatar pchote commented on May 18, 2024

Added f605793 as suggested above and requested in IRC.

from openramodsdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.