PHD2 no more build in Ubuntu PPA about phd2 HOT 7 CLOSED

Thanks @pchev I will take a look at the issues.

from phd2.

I just look more in detail at 94cafff and remark it suppress the option USE_SYSTEM_GTEST.
There is a libgtest-dev version 1.13 packaged with Ubuntu, maybe the more simple is to revive this option.

from phd2.

yes, reinstating USE_SYSTEM_GTEST is a good solution; the other thing I was thinking would be to make building the test executables optional and perhaps disabled by default. gtest is only needed for building the test executables, and those are not needed for the debian package.

from phd2.

It is good if we can keep the test, because the test are run as part of the build process and the build fail in case of error in the test.
This can detect an issue with the Eigen library like we have some years ago with the i386 version.

from phd2.

ah, that's great that the test is run as part of the ppa build! USE_SYSTEM_GTEST sounds like the right solution then. I'll put up a pr for that directly against master

from phd2.

#1153 should address the gtest issue

looking into fixing the cmake_minimum_required issue now...

from phd2.

@pchev I pushed another commit to #1153 's branch which allowed building on focal (cmake 3.16)

from phd2.