Code Monkey home page Code Monkey logo

Comments (11)

CyberAndrii avatar CyberAndrii commented on July 24, 2024 2

I don't think OpenMod will target .NET Framework anymore. net461 is no longer used and can be safely removed. Unturned plugins should now target either netstandard2.1 (recommended) or net48, though older versions will continue to work. DiFFoZ might correct me on that.

I agree that Microsoft.Extensions.* should be upgraded to v8. Looking at the breaking changes, I don't see any that are relevant to OpenMod. We will still need to test that with some plugins just in case. Other packages better not to touch.

from openmod.

Trojaner avatar Trojaner commented on July 24, 2024 1

Dropping .NET Framework and .NET Standard 2.0 seems like a good idea to me

from openmod.

rube200 avatar rube200 commented on July 24, 2024

There are some small changes for upgrading to microsoft.extensions.* 7 but not many breaking changes. (One of them maybe plugins recompilation)
Also it supports net462

from openmod.

sunnamed434 avatar sunnamed434 commented on July 24, 2024

Looking forward to hear more feedback from other contributors. If you're ok with that I make another branch which implements new feature, only Microsoft.* dependencies to 7/8 and tested with uScript, AviRockets (no hopes since its has no support by owner), RocketMod, and some plugins

from openmod.

sunnamed434 avatar sunnamed434 commented on July 24, 2024

Due to Microsoft.EntityFrameworkCore v 7/8 is required to use with .NET 6.0 (as a target framework), so, netstandard cannot be in this case

from openmod.

sunnamed434 avatar sunnamed434 commented on July 24, 2024

In this case the best we can do is use .netstandard2.1 (and allow to use net48 for plugins by it needs):

New NuGet packages (not a v 7/8 because those versions are for .NET Core 6.0, etc and they're not compatible with .net48 and .netstandard2.0/2.1):
Microsoft.EntityFrameworkCore v3.1.32 -> Microsoft.EntityFrameworkCore v5.0.17
Microsoft.Extensions* v3.1.32 -> Microsoft.Extensions.* v5.0.2
Pomelo.EntityFrameworkCore.MySql v3.2.7 -> Pomelo.EntityFrameworkCore.MySql v5.0.4

Since we will bump to 5.* major versions it will probably make less issues during testing and compatibility with other plugins

Breaking changes:
Pomelo.EntityFrameworkCore.MySql v5.0.4: on add db context UseMySql instead of direct connection string the server version is should be used

-- Correct me if you see any other breaking changes.

from openmod.

rube200 avatar rube200 commented on July 24, 2024

Microsoft.EntityFrameworkCore should not be a priority to update, but need to be in consideration just in case of breaking

from openmod.

sunnamed434 avatar sunnamed434 commented on July 24, 2024

Microsoft.EntityFrameworkCore is need to be updated because this package has dependency to some of the Microsoft.Extensions.* packages

from openmod.

CyberAndrii avatar CyberAndrii commented on July 24, 2024

Question is, are we gonna drop support for netstandard2.0 and .NET Framework (all versions)? If not, then it won't be possible to update Microsoft.EntityFrameworkCore to v5 since it only targets netstandard2.1. I don't think it should be a problem to only update Microsoft.Extensions.*. It is possible to override dependencies that EF Core needs be referencing higher versions of packages.

from openmod.

sunnamed434 avatar sunnamed434 commented on July 24, 2024

I'll test it with old Microsoft.EntityFrameworkCore and new Microsoft.Extensions if it goes well then no need to bump newer Microsoft.EntityFrameworkCore

I don't wish to use binding redirects for that, and also it will probably cause issues with API restrictions, and unexpected problems by other devs while using this API, would be great to use it for both packages v5.*

Depends on how you guys want, if you want we can remove support for netstandard2.0 and .NET Framework (all versions), and keep only .netstandard2.1, very interesting what consequences it would lead us for

from openmod.

DiFFoZ avatar DiFFoZ commented on July 24, 2024

OpenMod now only uses .NET Standard 2.1

from openmod.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.