Code Monkey home page Code Monkey logo

Comments (7)

shimwell avatar shimwell commented on June 12, 2024 1

Yes good question, currently it can't perform that download.

If I can map each s(a,b) thermal cross section to a particular element or elements then I can add a flag to include them or not.

Currently these are processed but not included in the database of available cross sections.

I shall look into it.

from openmc_data_downloader.

shimwell avatar shimwell commented on June 12, 2024

Ok i think I have a method for the command line tool

I can add a flag for -sab and accept a list of stings. Each entry must be in this list of acceptable names.

The input strings can be checked against acceptable names define here https://github.com/openmc-dev/openmc/blob/efcc0c158edcc3e389eb20a5c5ffc4e0a65ef554/openmc/data/thermal.py#L30-L77

Then the unique sab names can be match to the urls in the endf list of h5 files containing thermal cross sections (botton of this page

For the api usage I notice the openmc.material.add_s_alpha_beta sets a ._sab attribute so that can be used to check if there are sab requirments in the material object

https://github.com/openmc-dev/openmc/blob/efcc0c158edcc3e389eb20a5c5ffc4e0a65ef554/openmc/material.py#L697

Sorry this is taking me a little while as I have a few projects to close out at the moment

from openmc_data_downloader.

shimwell avatar shimwell commented on June 12, 2024

@AI-Pranto I have had a go at adding this feature in the latest PR merge #16 there are a few examples on the readme.

The pip install on PyPi has also been updated to v0.3.0 https://pypi.org/project/openmc-data-downloader/#history

I am keen to improve it if you have any suggestions

from openmc_data_downloader.

AI-Pranto avatar AI-Pranto commented on June 12, 2024

Sorry for the late response here.

LGTM, Thanks @shimwell!

Just one last request here, Currently we have neutrons and Tsl data only at a single temperature 294. Can we include neutrons data at 250 K, 293.6 K, 600 K, 900 K, 1200 K, and 2500 K? We can update our current ENDF-B-VII.1-NNDC data storage by downloading pre-processed data from openmc-data Is it ok with you?
@shimwell Did you face data storage limit in github?

from openmc_data_downloader.

shimwell avatar shimwell commented on June 12, 2024

Yep there is a storage limit per repo so I guess that each temperature could be a separate repo to avoid that.

The repos on this organisation currently make use of these scripts to download data and process it into h5 data.

They are all templates a single repository with library specific modifications

So I would need another base repository to template that would take a different approach

The new template would download from https://openmc.org/official-data-libraries/ extract and self commit to the repo using a GitHub action

This might take a little while to sort out and then extend to do different temperatures but it is certainly now on the todo list, thanks for the suggestion

from openmc_data_downloader.

AI-Pranto avatar AI-Pranto commented on June 12, 2024

Thanks, @shimwell :)

from openmc_data_downloader.

AI-Pranto avatar AI-Pranto commented on June 12, 2024

Fix by #16

from openmc_data_downloader.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.