Code Monkey home page Code Monkey logo

Comments (4)

hijkzzz avatar hijkzzz commented on June 5, 2024 1

We only referred to your directory file structure, and we developed everything else ourselves (Especially core RL technology and performance optimization). I don't think the directory structure and a few lines of comments have any real contribution.

from openrlhf.

hijkzzz avatar hijkzzz commented on June 5, 2024

Hello, our code is developed based on deepspeed and ray, while you used colossalai for development. Obviously it is completely impossible for us to be using the same technology stack.
Our framework uses step-wise RL, whereas yours uses single-step RL.
The core of a framework is performance optimization and hyperparameter tuning & PPO implementation details, not the directory structures/comments.
Finally, your colossalchat code also includes contributions from us, including PPO tuning and ray.

from openrlhf.

hijkzzz avatar hijkzzz commented on June 5, 2024

Colossalchat Team contacted me earlier about RL issues

image

The wechat history proves that colossalchat's core RL technology was supported by me.

image image

Our developers also contributed the ray components to colossalaichat
https://github.com/hpcaitech/ColossalAI/pull/3309/files

image

from openrlhf.

catqaq avatar catqaq commented on June 5, 2024

@binmakeswell
Thank you for the discussion.
Let's keep in touch in the future and work together to improve the RLHF ecosystem.

from openrlhf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.