Code Monkey home page Code Monkey logo

Comments (19)

mhdawson avatar mhdawson commented on June 11, 2024 1

It was this comment that confused me except for "important packages" tho, which would surely include node. However, they're pretty responsive to those.

from summit.

Ethan-Arrowood avatar Ethan-Arrowood commented on June 11, 2024

For example: DefinitelyTyped/DefinitelyTyped#59286 (comment)

When issues with the types are found, and a long list of folks are mentioned by the bot, it goes completely ignored. There are pros and cons to keeping our types in @types/node - this session should be sure to provide examples of both.

(And here is a link for all DefinitelyTyped discussions related to node: https://github.com/DefinitelyTyped/DefinitelyTyped/discussions?discussions_q=label%3A%22Pkg%3A+node%22 😅)

from summit.

benjamingr avatar benjamingr commented on June 11, 2024

It'd be awesome to implement the type annotations proposal experimentally in node core on top of something like swc for Node https://github.com/tc39/proposal-type-annotations

from summit.

ljharb avatar ljharb commented on June 11, 2024

That seems exceedingly premature when it’s still in stage 1 and likely to either stall or change drastically; but it’d be interesting as a project outside of core!

from summit.

benjamingr avatar benjamingr commented on June 11, 2024

That seems exceedingly premature when it’s still in stage 1 and likely to either stall or change drastically; but it’d be interesting as a project outside of core!

We've added (and removed) command line flags for very early features in the past and I think the sort of feedback the project would get would be very valuable. I am not suggesting anything that isn't strictly "experimental, may break don't rely on this" and if the proposal changes/stalls it can be moved to a third-party tool.

from summit.

ljharb avatar ljharb commented on June 11, 2024

@benjamingr sure, but this is language syntax - wouldn't v8 would have to support it anyways?

from summit.

mhdawson avatar mhdawson commented on June 11, 2024

When issues with the types are found, and a long list of folks are mentioned by the bot, it goes completely ignored. There are pros and cons to keeping our types in @types/node - this session should be sure to provide examples of both.

In advance it might be good to reach out to people at DT to see if the Node.js project collaborators could become "approvers" for @types/node.

from summit.

ljharb avatar ljharb commented on June 11, 2024

That's easy - you just have to make a PR and add the github usernames you want, and I'm sure they'll approve it.

from summit.

mhdawson avatar mhdawson commented on June 11, 2024

@ljharb good to hear, what I thought was important was to see if the project could "own" getting things approved without having to move out of DT. Not advocating one way or the other right now, just understanding our options. In terms of ongoing management of the list do you think we'd be able to sync the Node.js collaborators into the list who can approve? (ie when somebody becomes a Node.js collaborator they also gain the ability to approve DT PRs related to Node.js?)

from summit.

ljharb avatar ljharb commented on June 11, 2024

@mhdawson the users listed as owners in a DT package can land changes without TS team intervention - except for "important packages" tho, which would surely include node. However, they're pretty responsive to those.

I'm not sure how automateable keeping that list in sync would be, but doing it manually is certainly feasible.

from summit.

mhdawson avatar mhdawson commented on June 11, 2024

@ljharb I think the discussion was about the types for node.js itself not other packages so a bit confused by your answer. I thought the complaint was that approvals for changes to the Types for Node.js itself streched out.

from summit.

ljharb avatar ljharb commented on June 11, 2024

Yes, I know - @types/node is an npm package.

from summit.

ljharb avatar ljharb commented on June 11, 2024

Sorry for the confusion :-) i meant that @types/node is an important package.

from summit.

WaleedAshraf avatar WaleedAshraf commented on June 11, 2024

@Ethan-Arrowood How much time would you need for this session? Ideal guess?

from summit.

Ethan-Arrowood avatar Ethan-Arrowood commented on June 11, 2024

Assuming you are asking about time, I'd say whatever the default is. People have opinions about this, but I imagine if we come in with some structured questions/talking points we can keep to the normal time limit.

from summit.

WaleedAshraf avatar WaleedAshraf commented on June 11, 2024

Sorry for the typo. @Ethan-Arrowood
There is no default time. Minimum is 30min slot, max is you can run for 2 days. I suggest having some time limit defined. That will help attendees who are interested in this + other sessions.

from summit.

WaleedAshraf avatar WaleedAshraf commented on June 11, 2024

Hi,

I have created an initial draft for time schedule. Let me know if you are Ok with it. We can try to have the least amount of collapse with other sessions (though we can't avoid all). Feel free to share your suggestion/preference.

https://docs.google.com/spreadsheets/d/1WJpK6ZD43GaI-h-HOuHnG0DmQ8orkxFLbYJ_jUiXX54/edit?usp=sharing

from summit.

Ethan-Arrowood avatar Ethan-Arrowood commented on June 11, 2024

Yes 30 minutes should be fine. Thank you!

from summit.

WaleedAshraf avatar WaleedAshraf commented on June 11, 2024

Closing the issue as the event has passed. We haven't received the recordings from OpenJS Foundation. If we do in the future, I'll share the links here.

from summit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.