openimaging / miqa-web Goto Github PK

Unauthorized users trying to load the app should be redirected to the login page.

Currently you need to click on a decision (Bad, Good, Extra) , then click save to persist that decision to the DB.

Clicking a decision should immediately save the scan, and also record the note if there is anything typed into the note field.

Currently, the ⏩ icon that advances to the next scan is always grayed out. It should be enabled whenever the current scan is not the next scan.

Currently there is no indication that a user is logged in.

Currently you need to click on a decision (Bad, Good, Extra) , then click save to persist that decision to the DB.

Clicking a decision should immediately save the scan, and also record the note if there is anything typed into the note field.

found in

---> <Dataset> at src/views/Dataset.vue
       <VMain>
         <VApp>
           <App> at src/App.vue
             <Root>

I'm assuming it's due to this.

Requires OpenImaging/miqa#2

Fix up the frontend to use the new Django email sending abilities.

• Add an endpoint to django.js that calls the API endpoint
• Wire the Import button in the UI to call that method

Export is completely unimplemented and also kind of complicated, so ignore it for now.

This dialog: https://github.com/OpenImaging/miqa-phase1/blob/master/client/src/views/Dataset.vue#L732-L760

Currently the login field is using girderRest and does not reflect the actual login status.

The backend (Django) and the frontend (Vue) are now up and running on my machine but I've run into another issue - clicking on "Login" in the top right of the screen doesn't not (as one would expect) launch a modal to login or redirect to a login page.

Vue DevTools does show two events emitted upon click:

name: "login"
type: "$emit"
source: ""
payload: Array[0]

and

name: "click"
type: "$emit"
source: ""
payload: Array[1]
0: MouseEvent

No messages are logged in the browser console.

I did notice that Login.vue contains several references to girderRest and that recent changes in miqa-web have shown these being renamed to djangoRest. Changing these values does not correct the issue...but that is as far as I've progressed thus far.

In girder the experiment name is actually a link to something XNAT related: https://github.com/OpenImaging/miqa-phase1/blob/master/client/src/views/Dataset.vue#L544-L550

This link should still work the same.

1. I have django miqa up and running using the included docker-compose files on my local system (Ubuntu 20.04).
2. I also cloned miqa-web onto my local system. I'm running node 14.16.1.
3. I performed npm install and then npm run serve.
4. I navigate to http://localhost:8081/ and it properly loads the credentials
5. It redirects me to:

http://localhost:8000/accounts/login/?next=/oauth/authorize/%3Fredirect_uri%3Dhttp%253A%252F%252Flocalhost%253A8081%252F%26client_id%3DcBmD6D6F2YAmMWHNQZFPUr4OpaXVpW5w4Thod6Kj%26response_type%3Dcode%26state%3D3Ihh5Z9VoJ%26response_mode%3Dquery%26code_challenge%3DteCu5YVMhL8ahnXzLu9zK43-ShoErfNI92x0XVVzE8E%26code_challenge_method%3DS256

With HTML entities decoded and some line breaks for formatting:

http://localhost:8000/accounts/login/?next=/oauth/authorize/
?redirect_uri=http%3A%2F%2Flocalhost%3A8081%2F
&client_id=cBmD6D6F2YAmMWHNQZFPUr4OpaXVpW5w4Thod6Kj
&response_type=code
&state=3Ihh5Z9VoJ
&response_mode=query
&code_challenge=teCu5YVMhL8ahnXzLu9zK43-ShoErfNI92x0XVVzE8E
&code_challenge_method=S256

6. After logging in I'm redirected to:

http://localhost:8000/oauth/authorize/?redirect_uri=http%3A%2F%2Flocalhost%3A8081%2F&client_id=cBmD6D6F2YAmMWHNQZFPUr4OpaXVpW5w4Thod6Kj&response_type=code&state=lr7yE4DBsV&response_mode=query&code_challenge=5p_c3qkYEAv0z5fIBl0sJy3MWbL3qosJ6Mk-R_O2j-Y&code_challenge_method=S256

Pretty formatted:

http://localhost:8000/oauth/authorize/?
redirect_uri=http://localhost:8081/
&client_id=cBmD6D6F2YAmMWHNQZFPUr4OpaXVpW5w4Thod6Kj
&response_type=code
&state=lr7yE4DBsV
&response_mode=query
&code_challenge=5p_c3qkYEAv0z5fIBl0sJy3MWbL3qosJ6Mk-R_O2j-Y
&code_challenge_method=S256

(state and code_challenge values have changed from 1st url)

And the page displays the error:

Error: invalid_request
Invalid client_id parameter value.

Not sure if anyone else has experienced this? I'm going to blow away my django backend and try a completely new install and see if that makes a difference.

Help is welcome, but mainly I wanted to record this here in case anyone else runs into the same problem. I'll update this issue as I progress.

Running Application Maintenance

Below I start fresh with django miqa I realized I should walk through the maintenance steps in the README.md. I did. I then used docker-compose up and navigated to http://localhost:8081, I briefly saw the Vue UI and then was redirected to localhost:8000 with the same error.

I then tried stopping the Vue frontend and restarting it. This did not resolve the issue.

Whenever the Save button is clicked or a decision is made, the scan should be saved, then the next scan should be loaded (if the current scan is not the last scan). There should be a snackbar that pops up to alert the user that this happened.

When the scan ABCDEF_123 has been marked as Good, it should appear in the scan list as ABCDEF_123 (G).

Changing window/level with the mouse in the render window should reflect in the slider value.

The Bad decision button should be disabled as long as there are notes in the history and there is nothing typed into the notes field.