Allow modification of the message after successful authorization about appauth-js HOT 7 CLOSED

I can see that this will be useful to more developers. I will add this API to NodeBasedHandler.

from appauth-js.

You can customize node_request_handler.ts to change the message already.
https://github.com/openid/AppAuth-JS/blob/master/src/node_support/node_request_handler.ts#L91

Did you mean that you needed a dedicated api in NodeRequestHandler for this use-case?

from appauth-js.

Yes, I was trying to get this done without forking. I am not sure where in the API would this fit but as mentioned above, the current message in most of the use cases is not very suitable as the user will have other tabs open. Being able to customize the message would be greatly beneficial from a UX point of view.

from appauth-js.

This is quite important, especially if we take into account the need for internationalization.
@tikurahul do you still have plans to implement this? Or should I make a pull request?

from appauth-js.

The message shown is just part of the sample app, right? Fundamental use of the library (which admittedly isn't documented very clearly) doesn't show any messages to the user.

For a sample of using AppAuth without any sample-code intermingled within it, take a look at what I've done at https://github.com/ForgeRock/appAuthHelper

from appauth-js.

My original intention was that forks would allow for changing things like UI.
The library was mostly doing enough plumbing to get out of your way - and subsequent rebases would be cheap.

from appauth-js.

The message shown is just part of the sample app, right? Fundamental use of the library (which admittedly isn't documented very clearly) doesn't show any messages to the user.

For a sample of using AppAuth without any sample-code intermingled within it, take a look at what I've done at https://github.com/ForgeRock/appAuthHelper

No, it's not part of the sample app, it's part of node_request_handler.ts. It would be pretty trivial to allow a string to be passed to the constructor of NodeBasedHandler. It is not simple to extend that class just to change the response string unfortunately.

from appauth-js.