Code Monkey home page Code Monkey logo

Comments (7)

tikurahul avatar tikurahul commented on June 16, 2024 4

I can see that this will be useful to more developers. I will add this API to NodeBasedHandler.

from appauth-js.

tikurahul avatar tikurahul commented on June 16, 2024

You can customize node_request_handler.ts to change the message already.
https://github.com/openid/AppAuth-JS/blob/master/src/node_support/node_request_handler.ts#L91

Did you mean that you needed a dedicated api in NodeRequestHandler for this use-case?

from appauth-js.

stanislavHamara avatar stanislavHamara commented on June 16, 2024

Yes, I was trying to get this done without forking. I am not sure where in the API would this fit but as mentioned above, the current message in most of the use cases is not very suitable as the user will have other tabs open. Being able to customize the message would be greatly beneficial from a UX point of view.

from appauth-js.

francisco-maciel avatar francisco-maciel commented on June 16, 2024

This is quite important, especially if we take into account the need for internationalization.
@tikurahul do you still have plans to implement this? Or should I make a pull request?

from appauth-js.

jakefeasel avatar jakefeasel commented on June 16, 2024

The message shown is just part of the sample app, right? Fundamental use of the library (which admittedly isn't documented very clearly) doesn't show any messages to the user.

For a sample of using AppAuth without any sample-code intermingled within it, take a look at what I've done at https://github.com/ForgeRock/appAuthHelper

from appauth-js.

tikurahul avatar tikurahul commented on June 16, 2024

My original intention was that forks would allow for changing things like UI.
The library was mostly doing enough plumbing to get out of your way - and subsequent rebases would be cheap.

from appauth-js.

shadow-light avatar shadow-light commented on June 16, 2024

The message shown is just part of the sample app, right? Fundamental use of the library (which admittedly isn't documented very clearly) doesn't show any messages to the user.

For a sample of using AppAuth without any sample-code intermingled within it, take a look at what I've done at https://github.com/ForgeRock/appAuthHelper

No, it's not part of the sample app, it's part of node_request_handler.ts. It would be pretty trivial to allow a string to be passed to the constructor of NodeBasedHandler. It is not simple to extend that class just to change the response string unfortunately.

from appauth-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.