[transaction] Multiple calls to get temp, humidity, and get_version no-op about org.openhab.binding.zwave HOT 20 CLOSED

It looks like sensor_multilevel is sending incorrect commands in this branch - not sure why, but I've added a test and it does detect the problem. That probably covers the first 2 issues (or at least part of them) - the reason it repeats is because the binding asks for a certain sensor, but the device returns a different one - so it asks again...

I've not looked at the other 2 issues yet - probably one for tomorrow night...

from org.openhab.binding.zwave.

I've just pushed an update that will hopefully fix the multilevel sensor issue.

from org.openhab.binding.zwave.

Great. I just pulled build 62, and will test it tonight or tomorrow morning.

from org.openhab.binding.zwave.

The sensor multilevel reporting is looking much better. Thanks.

from org.openhab.binding.zwave.

I think I’ve now fixed the multiple requests for the MANUFACTURER information - this will get pushed tonight hopefully.

from org.openhab.binding.zwave.

Ok. I should be able to pull down the new build tonight, but I might not be able to test it until Sunday.

from org.openhab.binding.zwave.

No probs - I’ve just pushed the latest update. I’ll try and look over the no-op issue as well before Sunday...

from org.openhab.binding.zwave.

I also found a bug in no-op processing, so that might also be fixed now (although not 100% sure).

from org.openhab.binding.zwave.

Ok. I see there's a build 65 on CB. Does that one have the no-op fix?

from org.openhab.binding.zwave.

from org.openhab.binding.zwave.

Ok. I downloaded 65 and have it installed. I'm VPN'ed into home, so I can't wake up any of the battery devices. I'll just have to wait for them to wake up on their own. :-(

from org.openhab.binding.zwave.

For Node 9, I'm still seeing repetitive version_command_class_get no_op requests starting at 16:53.46, 16:54:25, 16:56:21, etc. in the logs. Again, I'm not sure if this is a device issue, database issue, or binding issue.

For nodes 5 and 7, I'm seeing frequent and repetitive get requests being sent when it appears the devices are asleep, but perhaps I'm not interpreting that correctly. Are these possibly poll requests that are supposed to be queued and sent when the device wakes up?

Other than the above two questions, this version is looking pretty solid.

Sorry, forgot to attach the log...
zwave.txt

from org.openhab.binding.zwave.

Can you send an updated log?

I doubt the no-op issue is database or device. I know that there’s a problem with this during startup - not in this branch specifically, but in the binding somewhere.

I’d be interested in the sleeping thing - maybe this transaction manager bypasses the wakeup class queue - I see another test coming for this...

On 3 Sep 2016, at 12:15, Mark Hilbush [email protected] wrote:

For Node 9, I'm still seeing repetitive version_command_class_get no_op requests starting at 16:53.46, 16:54:25, 16:56:21, etc. in the logs. Again, I'm not sure if this is a device issue, database issue, or binding issue.

For nodes 5 and 7, I'm seeing frequent and repetitive get requests being sent when it appears the devices are asleep, but perhaps I'm not interpreting that correctly. Are these possibly poll requests that are supposed to be queued and sent when the device wakes up?

Other than the above two questions, this version is looking pretty solid.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub #64 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AA_kQ-oq_mas8P2ksRhKWyDOFE5-PU2Uks5qmVbpgaJpZM4Jym1Y.

from org.openhab.binding.zwave.

Yeah, as soon as I hit comment I realized I forgot to attach the log. :-o Comment above was edited to include the log.

from org.openhab.binding.zwave.

Thanks ;)

from org.openhab.binding.zwave.

NO_OP problem should now be fixed. I’d fixed this in the master branch a while back, but it must have been after the transaction branch was split and it didn’t merge for some reason...

from org.openhab.binding.zwave.

Confirming no-op is fixed in build 71.

from org.openhab.binding.zwave.

@mhilbush do you think we can close this or is something still missing? I'm tempted to close and open another issue if we find something as I've lost track of what is still open in this.

from org.openhab.binding.zwave.

The only thing I'm not sure about was that the binding was sending transactions to battery devices while they were asleep. If this is resolved, or will be resolved in the rework of the queuing, then this can be closed.

from org.openhab.binding.zwave.

Yep - good point. I’m not sure if I fixed that, but it is/was an issue. I’ll close this and make a specific issue…

On 16 Sep 2016, at 19:43, Mark Hilbush [email protected] wrote:

The only thing I'm not sure about was that the binding was sending transactions to battery devices while they were asleep. If this is resolved, or will be resolved in the rework of the queuing, then this can be closed.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub #64 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AA_kQzRrpfo1IGmuebGP6FcWqfS50j1mks5qqtVFgaJpZM4Jym1Y.

from org.openhab.binding.zwave.