Code Monkey home page Code Monkey logo

Comments (14)

liangyuanruo avatar liangyuanruo commented on July 29, 2024 1

Subject: 'Form Title' secret key shared with you

Suggest to move the form title to the back because it can be rather long

from formsg.

jonathangohjy avatar jonathangohjy commented on July 29, 2024 1

@syan-syan Updated some screens on Zeplin for this flow. Here

from formsg.

mantariksh avatar mantariksh commented on July 29, 2024 1

@syan-syan keeping this issue open until we decide on the final design

from formsg.

mantariksh avatar mantariksh commented on July 29, 2024

@syan-syan Unfortunately it's not easy to have the form link in the email, as at the point of downloading the secret key, the form hasn't actually been created in the database as yet. If we really need to include it, we'll need to create the form in the db earlier, then delete it in case the user exits the modal. You ok with including the form title but not form link?

from formsg.

mantariksh avatar mantariksh commented on July 29, 2024

also @syan-syan I don't think it's possible to request a read receipt for the email since we're not the ones sending it, @liangyuanruo do you know if there's a way for us to do that?

from formsg.

r00dgirl avatar r00dgirl commented on July 29, 2024

@syan-syan Unfortunately it's not easy to have the form link in the email, as at the point of downloading the secret key, the form hasn't actually been created in the database as yet. If we really need to include it, we'll need to create the form in the db earlier, then delete it in case the user exits the modal. You ok with including the form title but not form link?

Yup ok lets just include the form title and not the link for the create secret key modal.

(We could also create the form first and then popup the modal again when the user tries to access from dashboard, which is prob a better UX overall, but since that would require us to remember if they had downloaded the key or not, I think its ok not to make this change until needed)

Would it be messy (code wise) to have another secret key mailto at form activation (where it says 'email two colleagues') in the activate modal that fills in the form link? @mantariksh

from formsg.

mantariksh avatar mantariksh commented on July 29, 2024

@syan-syan nah not messy, it's p easy. what dyou mean by 'email two colleagues'? As in put that as the link text?

from formsg.

r00dgirl avatar r00dgirl commented on July 29, 2024

@mantariksh argh sorry these notifs are going to junk! in the activate modal theres a part of the text that says 'email two colleagues' we can put in a secret key mailto link there too that does fill in the form link.

from formsg.

mantariksh avatar mantariksh commented on July 29, 2024

@syan-syan hmm it's slightly more complicated because in the activate form modal, we don't actually verify whether whatever the user has typed in the secret key box is correct until after they click "Activate Form". This means for e.g. they might upload the wrong secret key, then email that wrong secret key to colleagues, then later realise it was the wrong secret key. Probs worth thinking about this more before implementation, will raise at syncup

from formsg.

r00dgirl avatar r00dgirl commented on July 29, 2024

as discussed w pearly and @mantariksh

preferred: 'permanent' green toaster on top of activate button with copy β€œForm activated! Email secret key to colleagues for safekeeping.” and link on the second sentence.

if too troublesome, then regular 10s toaster saying the same thing.

in both cases, replace the two current success toasters that last ~2s each

from formsg.

r00dgirl avatar r00dgirl commented on July 29, 2024

also @syan-syan I don't think it's possible to request a read receipt for the email since we're not the ones sending it, @liangyuanruo do you know if there's a way for us to do that?

@liangyuanruo @mantariksh if we are not able to find out if the email was actually sent, let's put a GA event on the Email link click?

also @mantariksh we need to put this on activation as well as described above, but bounce handling is more impt right now so we can q that after

from formsg.

mantariksh avatar mantariksh commented on July 29, 2024

lol @syan-syan mailto for activate modal, GA event and bounce handling are all alr done. Except the GA event is only on the create form mailto and not the activate modal mailto, as it's not possible to put a GA event on a toastr link as far as I can tell.

from formsg.

r00dgirl avatar r00dgirl commented on July 29, 2024

lol @syan-syan mailto for activate modal, GA event and bounce handling are all alr done. Except the GA event is only on the create form mailto and not the activate modal mailto, as it's not possible to put a GA event on a toastr link as far as I can tell.

@mantariksh my bad i saw the create but not activate in prod ytd. if it was already out, that may be a bad sign meaning its not obvious enough. we should delete the first toaster btw i.e. there should only be one toaster after activation, which is that one. can we increase duration to 20s?

from formsg.

pearlyong avatar pearlyong commented on July 29, 2024

@mantariksh can we change the copy slightly to make it a bit more succinct, keep it to one line, remove the Verified! toaster? this is the only toaster that should display https://zpl.io/beR8RGW

from formsg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.