Comments (14)
Subject: 'Form Title' secret key shared with you
Suggest to move the form title to the back because it can be rather long
from formsg.
@syan-syan Updated some screens on Zeplin for this flow. Here
from formsg.
@syan-syan keeping this issue open until we decide on the final design
from formsg.
@syan-syan Unfortunately it's not easy to have the form link in the email, as at the point of downloading the secret key, the form hasn't actually been created in the database as yet. If we really need to include it, we'll need to create the form in the db earlier, then delete it in case the user exits the modal. You ok with including the form title but not form link?
from formsg.
also @syan-syan I don't think it's possible to request a read receipt for the email since we're not the ones sending it, @liangyuanruo do you know if there's a way for us to do that?
from formsg.
@syan-syan Unfortunately it's not easy to have the form link in the email, as at the point of downloading the secret key, the form hasn't actually been created in the database as yet. If we really need to include it, we'll need to create the form in the db earlier, then delete it in case the user exits the modal. You ok with including the form title but not form link?
Yup ok lets just include the form title and not the link for the create secret key modal.
(We could also create the form first and then popup the modal again when the user tries to access from dashboard, which is prob a better UX overall, but since that would require us to remember if they had downloaded the key or not, I think its ok not to make this change until needed)
Would it be messy (code wise) to have another secret key mailto at form activation (where it says 'email two colleagues') in the activate modal that fills in the form link? @mantariksh
from formsg.
@syan-syan nah not messy, it's p easy. what dyou mean by 'email two colleagues'? As in put that as the link text?
from formsg.
@mantariksh argh sorry these notifs are going to junk! in the activate modal theres a part of the text that says 'email two colleagues' we can put in a secret key mailto link there too that does fill in the form link.
from formsg.
@syan-syan hmm it's slightly more complicated because in the activate form modal, we don't actually verify whether whatever the user has typed in the secret key box is correct until after they click "Activate Form". This means for e.g. they might upload the wrong secret key, then email that wrong secret key to colleagues, then later realise it was the wrong secret key. Probs worth thinking about this more before implementation, will raise at syncup
from formsg.
as discussed w pearly and @mantariksh
preferred: 'permanent' green toaster on top of activate button with copy βForm activated! Email secret key to colleagues for safekeeping.β and link on the second sentence.
if too troublesome, then regular 10s toaster saying the same thing.
in both cases, replace the two current success toasters that last ~2s each
from formsg.
also @syan-syan I don't think it's possible to request a read receipt for the email since we're not the ones sending it, @liangyuanruo do you know if there's a way for us to do that?
@liangyuanruo @mantariksh if we are not able to find out if the email was actually sent, let's put a GA event on the Email link click?
also @mantariksh we need to put this on activation as well as described above, but bounce handling is more impt right now so we can q that after
from formsg.
lol @syan-syan mailto for activate modal, GA event and bounce handling are all alr done. Except the GA event is only on the create form mailto and not the activate modal mailto, as it's not possible to put a GA event on a toastr link as far as I can tell.
from formsg.
lol @syan-syan mailto for activate modal, GA event and bounce handling are all alr done. Except the GA event is only on the create form mailto and not the activate modal mailto, as it's not possible to put a GA event on a toastr link as far as I can tell.
@mantariksh my bad i saw the create but not activate in prod ytd. if it was already out, that may be a bad sign meaning its not obvious enough. we should delete the first toaster btw i.e. there should only be one toaster after activation, which is that one. can we increase duration to 20s?
from formsg.
@mantariksh can we change the copy slightly to make it a bit more succinct, keep it to one line, remove the Verified! toaster? this is the only toaster that should display https://zpl.io/beR8RGW
from formsg.
Related Issues (20)
- When payment is not enabled on a form, a white box is still rendered where the payment preview usually is HOT 1
- Make responseMetadata required for submission controllers
- MongoDB host with srv scheme is not supported
- Dropdown options rendering outside of form creation tab HOT 5
- [FRM-1363] Test Issue | Public Label HOT 2
- [FRM-1364] Creating a new issue on github. Should appear on linear.
- [FRM-1365] Test open issue on GH
- [FRM-1387] wanling test issue for synclinear
- [FRM-1389] [FRM-1386] Ken test issue for synclinear
- [FRM-1390] [FRM-1388] Huiqing test synclinear issue!!
- [FRM-1393] [FRM-1392] [CF] Testing synclinear HOT 1
- [FRM-1394] ken test issue for synclinear HOT 2
- [FRM-1395] [FRM-1391] Sebastian test sync linear
- [FRM-1396] wanling test synclinear again HOT 1
- GOV.UK Forms
- [Feature Request] Request for REGEX validation
- Feature: Easier whitelisting of email domains (simple patterns or flags)
- Removal of all references to Singapore entities and proprietary services
- Difficulty in translating hardcoded text within nested React tags using i18next HOT 2
- feat: allow drag-and-drop of storage mode secret key HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from formsg.