Comments (5)
Assigning to myself first to spearhead a sample FP implementation that should simplify what we have today.
from formsg.
@jia1's PR on email domain restriction #143 may have some conflicts with the refactor; take note
from formsg.
Potential idea - do we want to refactor this away from class-based implementation to a functional implementation instead? the rationale being that validators are best implemented without having to hold state. also, we have good test coverage so it ought to be fairly safe to do so.
from formsg.
Reference implementation has been added in #409 . As usual, please add your name to the validator if you are working on it:
Validator
- Attachment (@tshuli #1181)
- Checkbox (@tshuli #1225)
- Date (@tshuli #749)
- Decimal (@tshuli #750)
- Dropdown (@tshuli #861)
- Email (@tshuli #1126 )
- HomeNo (@tshuli #704)
- Mobile (@tshuli #713)
- Nric (@liangyuanruo #639 )
- Number (@tshuli #1145 )
- Radiobutton (@tshuli #723)
- Rating (@tshuli #724)
- Section (@liangyuanruo #409)
- Table (@tshuli #1316 )
- Text (@liangyuanruo #409)
Tests
For safety of email submissions, these are to be ported from Jasmine to Jest after its corresponding validator has been migrated and running in production for at least a week.
- Attachment
- Checkbox
- Date
- Decimal
- Dropdown
- HomeNo
- Mobile
- Nric
- Number
- Radiobutton
- Rating
- Section
- Table
- Text
from formsg.
self-assigning a couple first to get more chances to practice :)
from formsg.
Related Issues (20)
- Measure normalized time to fill forms by respondents and track on a dashboard HOT 1
- Payment page payment item details may show inconsistent information from payment intent
- Modify release script to include deploy notes
- Add timeout for google captcha verification
- Refactor receipt/invoice generation
- FormSG Zapier: Add endpoint to retrieve sample submission data
- Explore disabling webhooks if it crosses a certain threshold of failures
- Add webkit browser back for playwright tests
- Restore download CSV responses flow to `encrypt-submission` playwright test suite
- Issues caused by bullet points for how text display in both form builder preview and in preview mode
- Webhooks: allow choosing which responses to be sent in payload
- Add metrics to track usage of locked prefills
- We should pin MockPass version in docker-compose
- Add backend code to support more sgID scopes
- Check for validation options when generating sample submission response
- Review email capacity for upcoming event launch
- Update payment setting page on UAT
- When payment is not enabled on a form, a white box is still rendered where the payment preview usually is HOT 1
- Make responseMetadata required for submission controllers
- MongoDB host with srv scheme is not supported
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from formsg.