Code Monkey home page Code Monkey logo

Comments (5)

liangyuanruo avatar liangyuanruo commented on July 29, 2024 1

Assigning to myself first to spearhead a sample FP implementation that should simplify what we have today.

from formsg.

karrui avatar karrui commented on July 29, 2024

@jia1's PR on email domain restriction #143 may have some conflicts with the refactor; take note

from formsg.

liangyuanruo avatar liangyuanruo commented on July 29, 2024

Potential idea - do we want to refactor this away from class-based implementation to a functional implementation instead? the rationale being that validators are best implemented without having to hold state. also, we have good test coverage so it ought to be fairly safe to do so.

from formsg.

liangyuanruo avatar liangyuanruo commented on July 29, 2024

Reference implementation has been added in #409 . As usual, please add your name to the validator if you are working on it:

Validator

Tests

For safety of email submissions, these are to be ported from Jasmine to Jest after its corresponding validator has been migrated and running in production for at least a week.

  • Attachment
  • Checkbox
  • Date
  • Decimal
  • Dropdown
  • Email
  • HomeNo
  • Mobile
  • Nric
  • Number
  • Radiobutton
  • Rating
  • Section
  • Table
  • Text

from formsg.

tshuli avatar tshuli commented on July 29, 2024

self-assigning a couple first to get more chances to practice :)

from formsg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.