Code Monkey home page Code Monkey logo

Comments (8)

walter avatar walter commented on July 19, 2024

Also a bit of UI tie-in for #22 on the person's page (if they are the person) if they have questions that are have met their threshold and are waiting to be answered.

I.e. this scenario:

  • user asks person a question
  • other users sign the question and it reach its threshold
  • recipient person is sent notification of question
  • person views their person page and can see that there is a question awaiting an answer with link to question (where they can answer it as per this issue)

The above should be able to handle more than one question awaiting an answer as well as "plain" questions (not yet at threshold, basically what we have now wherever we show questions).

from askthem.

walter avatar walter commented on July 19, 2024

@acacheung is this what you talking about handing over?

In future, add issue number (e.g. #45) to bottom of commit messages to have them show up under issue. Even when not closing them.

from askthem.

acacheung avatar acacheung commented on July 19, 2024

@walter yes, sorry about that. will remember for the future

from askthem.

walter avatar walter commented on July 19, 2024

Making sure that @derekeder and @evz see that this has been done.

from askthem.

walter avatar walter commented on July 19, 2024

@derekeder & @evz if you have what you need which I suspect is the case.

from askthem.

derekeder avatar derekeder commented on July 19, 2024

@walter yup I think we're ready to dive in to this one.

from askthem.

walter avatar walter commented on July 19, 2024

Ok, the HTML for this is actually what is causing our failing test. As @evz there are two #new_user forms on the page and the test fills out the wrong one as we result.

Not a big deal, but it led me to take a closer look at the HTML for this and I have a couple points of feedback that I think @derekeder and @evz can handle in their work.

  • for now, we'll wait and see if we need it in the future, let's drop the new user creation as a part of the answer form and wrap the form in logic that only shows it to a verified responder for the question (i.e. a user account that has an identity for the person that is the same as question.person as I emailed about)
  • the answer form should appear above the comments!

Until you guys get into the work, I'm going to disambiguate test to use 'within ".signup" do' to fill out the correct form.

from askthem.

derekeder avatar derekeder commented on July 19, 2024

Closed by #72

from askthem.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.