Comments (8)
Also a bit of UI tie-in for #22 on the person's page (if they are the person) if they have questions that are have met their threshold and are waiting to be answered.
I.e. this scenario:
- user asks person a question
- other users sign the question and it reach its threshold
- recipient person is sent notification of question
- person views their person page and can see that there is a question awaiting an answer with link to question (where they can answer it as per this issue)
The above should be able to handle more than one question awaiting an answer as well as "plain" questions (not yet at threshold, basically what we have now wherever we show questions).
from askthem.
@acacheung is this what you talking about handing over?
In future, add issue number (e.g. #45) to bottom of commit messages to have them show up under issue. Even when not closing them.
from askthem.
@walter yes, sorry about that. will remember for the future
from askthem.
Making sure that @derekeder and @evz see that this has been done.
from askthem.
@derekeder & @evz if you have what you need which I suspect is the case.
from askthem.
@walter yup I think we're ready to dive in to this one.
from askthem.
Ok, the HTML for this is actually what is causing our failing test. As @evz there are two #new_user forms on the page and the test fills out the wrong one as we result.
Not a big deal, but it led me to take a closer look at the HTML for this and I have a couple points of feedback that I think @derekeder and @evz can handle in their work.
- for now, we'll wait and see if we need it in the future, let's drop the new user creation as a part of the answer form and wrap the form in logic that only shows it to a verified responder for the question (i.e. a user account that has an identity for the person that is the same as question.person as I emailed about)
- the answer form should appear above the comments!
Until you guys get into the work, I'm going to disambiguate test to use 'within ".signup" do' to fill out the correct form.
from askthem.
Closed by #72
from askthem.
Related Issues (20)
- Add images for VA Senators HOT 1
- new users for action network HOT 1
- Staff member can designate user account as representing a partner organization HOT 1
- When asking user is partner organization, a question's TOS are updated to notify of sharing of signatures with partner organization
- Staff members can download CSV of question signers basic information HOT 1
- homepage copy fix
- issue w/ old session? HOT 6
- Internet slowdown day modal HOT 2
- Homepage blurbs not being set as default HOT 4
- increase height of HonestAds widget zip-code box - for FF visitors
- on /map, some city names show Q's, but none listed in /questions HOT 1
- A user's email address can be turned off for notifications HOT 1
- Process AWS SNS bounce notifications by disabling user's email
- images briefly broken on production HOT 6
- name alignment with profile photos got a little wonky HOT 3
- widget design enhancements - seeking volunteer time on useful new tools
- site-wide enhancements to info display & new features
- old verified Twitter avatars not displaying as expected? HOT 2
- PPF devops tasks January 2016 - for time estimates
- reboot site-wide Recent Questions view HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from askthem.