add-in sharing modal when Question is published about askthem HOT 10 CLOSED

@kidfribble this seems mostly frontend (except the trigger for the modal to be open).

Do you want to just implement it where all views of the question page get the modal and then I'll come back and implement the detection for whether it should be open or not after you are done?

from askthem.

Yeah that sounds good to me

On Jul 23, 2013, at 5:04 PM, Walter McGinnis [email protected] wrote:

@kidfribble this seems mostly frontend (except the trigger for the modal to be open).

Do you want to just implement it where all views of the question page get the modal and then I'll come back and implement the detection for whether it should be open or not after you are done?

—
Reply to this email directly or view it on GitHub.

from askthem.

Just assigning this - 8(a) on dev roadmap - to Steve, adding-in the banner as on Change with prompts to email/share a just-published Q/petition. Reassign to Walter to implement the next step of course.

from askthem.

Piggyback on modal designs & handoff to Amanda, new front-end dev

from askthem.

Hey Derek, the styles should be all set for the modal. I put them on questions show page. Passing it on so you can wire up the backend for this. Let me know if you have any questions.

from askthem.

@acacheung cool! @evz and I will dive in to it tomorrow.

from askthem.

@derekeder & @evz, I think your tying together of the modal work (frontend styles/js with controller/view logic) should allow us to get our tests back passing.

In other words, if "questions #show when displaying signature information allows new user to register and sign on to a question" is still failing after you finish your work, please adjust it to accurately describe our new expectations for the feature (a user should get a modal for sharing after asking a question).

from askthem.

@derekeder & @evz, if you can add screenshots of things here as you go, that would be handy.

from askthem.

Overlay is now showing when there is a created=true query parameter. I'll take a look at the specs next.

from askthem.

Closed with #64.

from askthem.