ShellCheck linter issues about opengapps HOT 7 OPEN

Reopen since #48 (comment) is still a solid idea 👍

from opengapps.

I will have a look at it.
I already did shellcheck some parts of the script before, but for some things we currently have no 'cleaner' possibilities available (but that we know we won't have issues, because we know that we e.g. don't have spaces in our own foldernames).

from opengapps.

I'm also looking at this. @mfonville Do you think we can replace printf on line 112 and 113 of add_sourceapp.sh with echo?

from opengapps.

I used there printf because it has no line-endings, but we could also use echo -n I guess.
You'll have to test carefully with the 'cut' though, if nothing breaks.

from opengapps.

echo flags are not portable. All scripts specify the #!/bin/sh shebang, which indicates that the scripts work with /bin/sh, but echo flags are a non-standard feature.

printf is portable and should always be used instead of echo with flags. Rather than replace printf with echo to silence SC2059 warnings, follow the ShellCheck warning and use format specifiers. It is worth noting that there are exceptions and sometimes you want to interpret data as a format string, as shown in the ShellCheck warning: hexToAscii() { printf "\x$1"; } hexToAscii 21

from opengapps.

I also want to integrate shellcheck checking of the update-binary output into the Github status API https://developer.github.com/v3/repos/statuses/ to give feedback if a commit would break the shellscript completely.

from opengapps.

Here's a new log against 9c728b1 in case developers are interested:
https://gist.github.com/anonymous/a73d099195a0b8215e8504151db5071d

shellcheck00.log was generated with the noisiest warnings disabled
SC2016,SC2034,SC2045,SC2153,SC2154,SC2164
shellcheck01.log was generated with all warnings enabled (default)

from opengapps.