Code Monkey home page Code Monkey logo

Comments (11)

PaulPaulDevelops avatar PaulPaulDevelops commented on May 27, 2024

@jedihacks could you update the description and provide more information on this issue?

from stencil-openforge.io-deprecated.

jedihacks avatar jedihacks commented on May 27, 2024

Sure thing!

To reproduce on /origin/develop branch; use 'npm start' from terminal. Then go to your localhost copy, and you should get the following error.

If you refresh/go to other pages; you'll see a couple other errors all relating to CSS & the Hydrator.

screen shot 2018-05-24 at 4 27 21 pm

from stencil-openforge.io-deprecated.

jedihacks avatar jedihacks commented on May 27, 2024

@luiskcs89

from stencil-openforge.io-deprecated.

luiskcs89 avatar luiskcs89 commented on May 27, 2024

I've found that there are some issues in jsdom related to this CSS parsing. The specific case of this screenshoot is due to last-child , but there are also issues when the font-family styles have spaces and so on. Some of the issues seem to be closed for newer versions of jsdom but stencil/core requires 11.5.1 which doesn't have those fixes.

from stencil-openforge.io-deprecated.

jedihacks avatar jedihacks commented on May 27, 2024

Is there anything we can do to override the errors for now, or are the errors having any adverse effects?

from stencil-openforge.io-deprecated.

luiskcs89 avatar luiskcs89 commented on May 27, 2024

From what I read, the errors don't have an adverse effect on the app, they just come from jsdom's css parser which doesn't support some legitimate CSS features (jsdom/jsdom#2177 (comment)). Looks like there is nothing we can do about this from our side.

from stencil-openforge.io-deprecated.

Wholloran avatar Wholloran commented on May 27, 2024

Need to update rules for JSdom to silence CSS errors

from stencil-openforge.io-deprecated.

luiskcs89 avatar luiskcs89 commented on May 27, 2024

Actually I am not seeing these error logs anymore on the current develop branch and this issue could probably be closed.

from stencil-openforge.io-deprecated.

Wholloran avatar Wholloran commented on May 27, 2024

@daftclaud Can you confirm this is resolved on Thursday and If so close the defect.

from stencil-openforge.io-deprecated.

Wholloran avatar Wholloran commented on May 27, 2024

Confirmed with Claudio that this can be closed. So Closing ticket

from stencil-openforge.io-deprecated.

daftclaud avatar daftclaud commented on May 27, 2024

Just a comment: make sure you run npm run start as opposed to just npm start

from stencil-openforge.io-deprecated.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.