Code Monkey home page Code Monkey logo

Comments (3)

mattwthompson avatar mattwthompson commented on June 21, 2024

Quick thoughts now, might add more later - happy to look at a PR for any of this!

  • Using LAMMPS's Python wrapper is better than the raw parsing Interchange currently uses
  • All current OpenFF use cases work fine with real and might not work well with other styles, or I don't understand biophysics use cases in which other styles are valuable
  • I'm apprehensive about different unit systems creeping out into the core API or our infrastructure more generally; the behavior within a LAMMPS submodule can be whatever as long as there's some consistency in what's reported out of it (i.e. get_lammps_energies)

from openff-interchange.

timbernat avatar timbernat commented on June 21, 2024
  • Using LAMMPS's Python wrapper is better than the raw parsing Interchange currently uses
    I'm in agreement there!
  • All current OpenFF use cases work fine with real and might not work well with other styles, or I don't understand biophysics use cases in which other styles are valuable
    Admittedly neither do I, I mostly included this for the sake of generality to have (if nothing else) an API-compatible reference of the LAMMPS styles
  • I'm apprehensive about different unit systems creeping out into the core API or our infrastructure more generally; the behavior within a LAMMPS submodule can be whatever as long as there's some consistency in what's reported out of it (i.e. get_lammps_energies)
    That makes perfect sense, were I to put together a PR for this, I'd rewrite using OpenFF/pint units (I only wrote in using OpenMM units because that's what I prefer to use day-to-day :) ). An additional wrinkle regardless of the unit engine chosen is that LAMMPS in certain places uses units not defined by default in either openmm.unit or in the Default pint UnitRegistry (e.g. electronvolts, statcoulombs, hertz). I've written my own definitions of these additional units, which would have to be also be done if using the OpenFF unit system.

from openff-interchange.

mattwthompson avatar mattwthompson commented on June 21, 2024

One of the text files here controls which are exposed by our registry, which is mostly Pint's default with macro-scale units stripped out. Adding units to the registry is nearly free, so anything that might be useful for your work (eV, etc.) is probably useful for others and can be added

https://github.com/openforcefield/openff-units/tree/cfdb193b6718776a00fde378afb17617d2dfabb0/openff/units/data

from openff-interchange.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.