Comments (3)
I think this is a holdover from the days when we thought that we could have a "pre-parameterization interchange" - Like, we could add two unparameterized molecules loaded from different places, and later apply a FF to them. We decided at some point that Interchanges would strictly be "post-parameterization", and in that context I think this ticket is totally closed. If there's a use case I'm not imagining here, folks can reopen this/open a new issue.
from openff-interchange.
Something to consider is that, when mixing two force fields from a line (i.e. Parsley), each SMIRKS in a potential handler is not guaranteed to be unique if not tracking the force field each is associated with. The SMIRKS patterns between versions of Parsley are mostly the same, and there is plenty of overlap between those and smirnoff99Frosst.
Maybe the best way to handle this is also track the source force field in the PotentialKey
objects.
from openff-interchange.
The __add__
functionality added in #148 may or may not do this clearly. I have not tested it yet. The Parsley + GAFF/ff19sb case should be mostly covered by testing if Parsley + Foyer-style force fields can co-exist.
from openff-interchange.
Related Issues (20)
- Support LJPME in OpenMM export HOT 1
- Support LJPME in GROMACS export
- Support LJPME in LAMMPS export
- Time value in inpcrd is messing up VMD visualization HOT 3
- from_openmm GAFF molecule cannt write to AMBER HOT 2
- `Interchange.to_pdb` does not work with `_SimpleAtom`s HOT 1
- Change installation instructions to recommend `mamba create` instead of `conda install`
- Allow electrostatics in single force + plugins HOT 4
- `_simple_topology_from_openmm` fails with `RecursionError` on large topologies HOT 5
- vdW energies not reported when vdW interactions defined by plugins HOT 1
- Improve error handling with missing parameters
- Boxes from OpenMM `System`s are `OpenFFQuantity[list[list[OpenMMQuantity]]]` HOT 13
- Check if masses in OpenMM are canonical or edited a la HMR HOT 2
- Support HMR in OpenMM export HOT 1
- Support HMR in GROMACS export HOT 4
- Better support bond constraints in LAMMPS export HOT 2
- NADP gives some inconsistent energies across engines. HOT 4
- [LAMMPS] Full unit-awareness when parsing LAMMPS outputs with drivers HOT 3
- Missing v-site exceptions HOT 4
- Wrong "scale_14" read from .json file HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openff-interchange.