Code Monkey home page Code Monkey logo

Comments (3)

j-wags avatar j-wags commented on May 28, 2024 1

I think this is a holdover from the days when we thought that we could have a "pre-parameterization interchange" - Like, we could add two unparameterized molecules loaded from different places, and later apply a FF to them. We decided at some point that Interchanges would strictly be "post-parameterization", and in that context I think this ticket is totally closed. If there's a use case I'm not imagining here, folks can reopen this/open a new issue.

from openff-interchange.

mattwthompson avatar mattwthompson commented on May 28, 2024

Something to consider is that, when mixing two force fields from a line (i.e. Parsley), each SMIRKS in a potential handler is not guaranteed to be unique if not tracking the force field each is associated with. The SMIRKS patterns between versions of Parsley are mostly the same, and there is plenty of overlap between those and smirnoff99Frosst.

Maybe the best way to handle this is also track the source force field in the PotentialKey objects.

from openff-interchange.

mattwthompson avatar mattwthompson commented on May 28, 2024

The __add__ functionality added in #148 may or may not do this clearly. I have not tested it yet. The Parsley + GAFF/ff19sb case should be mostly covered by testing if Parsley + Foyer-style force fields can co-exist.

from openff-interchange.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.