Code Monkey home page Code Monkey logo

Comments (12)

ivanayov avatar ivanayov commented on June 15, 2024

Derek add label: help wanted

from workshop.

mario-mazo avatar mario-mazo commented on June 15, 2024

I will take this

from workshop.

mario-mazo avatar mario-mazo commented on June 15, 2024

@ivanayov not sure if it makes sense to make the PR against the kubernetes-preview. They seem to be quite far apart.

 git diff --stat master remotes/origin/kubernetes-preview
 README.md |  18 +++-----------
 lab1.md   | 111 +++--------------------------------------------------------------------------------
 lab10.md  |  22 +++++++++++++++++
 lab1a.md  |  90 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 lab1b.md  | 152 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 lab2.md   |  40 +++++++++++++++++++++++++++++-
 lab3.md   |   8 ++++++
 lab4.md   |  23 +++++++++++++++---
 lab5.md   |  26 ++++++++++++++++++--
 lab7.md   |   8 ++++++
 lab9.md   |  37 +++++++++++-----------------
 11 files changed, 385 insertions(+), 150 deletions(-)

from workshop.

ivanayov avatar ivanayov commented on June 15, 2024

@mario-mazo it seems like you have some extra commits. Did you checkout from kubernetes-preview or from master?

from workshop.

alexellis avatar alexellis commented on June 15, 2024

Please can you do a PR to both?

Thanks,

Alex

from workshop.

alexellis avatar alexellis commented on June 15, 2024

What we're looking for is the following:

  1. PR from/to kubernetes-preview which updates Swarm & K8s instructions to use the faas-cli to create secrets when put in openfaas-fn (only)
  2. PR from/to master to update only the Swarm instructions to use faas-cli` to create secrets

Would you like to go ahead with this, or do you want us to pick it up?

Alex

from workshop.

mario-mazo avatar mario-mazo commented on June 15, 2024

ok will try to do the swarm part tonight and test it as I have not much experience with that swarm an submit both PRs tomorrow during the day.

from workshop.

alexellis avatar alexellis commented on June 15, 2024

@ivanayov please can you do a final pass for the word "secret" in both branches before we close out this issue?

from workshop.

alexellis avatar alexellis commented on June 15, 2024

@mario-mazo great job, looking forward to more PRs soon 🎉

from workshop.

ivanayov avatar ivanayov commented on June 15, 2024

@alexellis I verified it's all covered

from workshop.

alexellis avatar alexellis commented on June 15, 2024

Derek close: fixed

from workshop.

alexellis avatar alexellis commented on June 15, 2024

Great 👍

from workshop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.