Code Monkey home page Code Monkey logo

Comments (3)

alexellis avatar alexellis commented on June 15, 2024

Hi @kyeett I would prefer you to raise a PR for this.

You will however need to sign off your commits. Let me know if you need any help with that. For me I just do git commit -s instead of git commit.

Alex

from workshop.

magnuswahlstrand avatar magnuswahlstrand commented on June 15, 2024

Hi @alexellis.

I seem to have deleted my old fork where I did the initial pull request, created a new one here: #115
I created the change directly on github, so I can't commit from the cli. I believe I managed to sign it manually in the commit message. Please have a look.

Best regards,
Magnus

from workshop.

rgee0 avatar rgee0 commented on June 15, 2024

Fixed in #115

from workshop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.