Stopping faasd and faasd-provider should stop all containers about faasd HOT 4 CLOSED

Apparently Prometheus is preventing the stop to proceed. I changed :

File up.go

91: 		log.Printf("Signal received.. shutting down server in %s\n", shutdownTimeout.String())
92: 		err := supervisor.Remove(services)
93: 		if err != nil {
94: 			fmt.Printf("Error removing services: %s\n", err)
95: 		}

And got:

Mar 09 09:30:36 debian10 faasd[18159]: Error removing services: error deleting container prometheus, prometheus, cannot delete running task prometheus: failed precondition

What is weird is that Prometheus stopped thru faasd never prints it's last message like stopping it manually with kill -TERM pid:

Mar 09 10:05:56 debian10 faasd[21350]: level=info ts=2020-03-09T14:05:56.616Z caller=notifier.go:602 component=notifier msg="Stopping notification manager..."
Mar 09 10:05:56 debian10 faasd[21350]: level=info ts=2020-03-09T14:05:56.616Z caller=main.go:727 msg="Notifier manager stopped"
Mar 09 10:05:56 debian10 faasd[21350]: level=info ts=2020-03-09T14:05:56.616Z caller=main.go:739 msg="See you next time!"

from faasd.

One issue I believe @alexellis might need to direct is how the provider should behave related to deployed functions.

Since faasd-provider does not keep the state, if it is stopped and the functions deleted, when started back the functions would not be recreated.

One option would be just stopping the functions (killing it's tasks) but keeping the container so in the event of a restart, faasd-provider would scale it back to 1 on access.

What do you think?

from faasd.

Why do you feel that is this change required? (I may not understand the problem well enough, I'm listening)

from faasd.

/lock: closed

from faasd.