Comments (2)
Another issue with modals is that some take props for show and the close function. Hopefully the changes for this issue could also eliminate those and maybe all props.
from oed.
The same idea has also occured to me, and I've got some changes to admin pages undergoing tentative development that address this concept.
With the migration to rtk, react-router was also updated to v6. This introduced <Outlets/> which is currently being utilized for the admin pages.
The approach I've begin to look into is using a single modal, who's contents get dynamically swapped depending on the page, etc.
This differs with the current approach that creates a modal for each entity view.
This Admin Outlet has a SharedModal between all admin pages.
The only real difference to the current implementation of the current the admin pages, is that the entity views only return the body contents instead of a full modal. While there are minor changes to the admin pages, the functionality is largely the same, except for the return value which now returns the modal 'body, only. The new approch would still use react-state, but will also be saving backedup local edits to the redux state. So previous code will likely not change much for many of the components.
from oed.
Related Issues (20)
- standardize translation method HOT 1
- maps handling negative values better HOT 1
- notify user if rate limit hit HOT 2
- remove unused timezone code HOT 1
- meter reading duplication should be drop-down menu HOT 1
- don't allow cumulative reset without cumulative on meter HOT 1
- unit with suffix has displayable of none HOT 1
- standard choices for sec. in rate HOT 2
- CSV meter upload validates values HOT 1
- confirm unit delete HOT 1
- graphical display of units/conversions HOT 2
- history does not load correct map HOT 1
- Weather data
- dropdown for all interval choices HOT 1
- custom interval for compare and map HOT 1
- merge meters and group menus
- client-side conversion
- Enable reading rejection if outside bounds & work with units
- VSC dev container fails to start
- Nice to have: Discard button in admin settings HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oed.