Comments (5)
If react-notification-system is not actively maintained or does not have a compatible version for React 16, consider exploring alternative notification packages. There are several other notification libraries available for React that might suit your needs and are more up-to-date with React's latest versions. Some popular options include {react-toastify}, {react-notifications}, and {react-sweet-alert}.
from oed.
It seems this has been fixed by e4ca15b
from oed.
I also stumbled upon this issue when developing #879, and fixed it with 5ce9935, but that is no longer needed since react-notification-system
is no longer used
from oed.
Thanks to everyone who looked into this. It does appear that OED is not actively using react-notification-system. It seems that src/client/app/utils/notifications.ts is using react-toastify. Thus, I propose we remove it from the code base. Here are the items I know of:
- Uninstall from package.json and package-lock.json.
- Remove all the commented out code involving react-notification-system in code and comments.
- Make sure the comment in src/scripts/installOED.sh about the issue is cleaned up.
- Remove all references to NotificationSystem.
- Maybe something else :-)
The hope is this should be fairly straightforward to finish.
from oed.
As @hyperupcall noted, I removed react-notification-system
in e4ca1. Looks like I forgot to remove the related types
package. This was something I had done as part of the React and node update effort, and I never had the time to properly finish after the end of the semester.
from oed.
Related Issues (20)
- CSS: centralize styles, combine, limit usage
- standardize translation method HOT 1
- maps handling negative values better HOT 1
- notify user if rate limit hit HOT 2
- remove unused timezone code HOT 1
- meter reading duplication should be drop-down menu HOT 1
- don't allow cumulative reset without cumulative on meter HOT 1
- unit with suffix has displayable of none HOT 1
- standard choices for sec. in rate HOT 2
- CSV meter upload validates values HOT 1
- confirm unit delete HOT 1
- graphical display of units/conversions HOT 2
- history does not load correct map HOT 1
- Weather data
- dropdown for all interval choices HOT 1
- custom interval for compare and map HOT 1
- merge meters and group menus
- client-side conversion
- Enable reading rejection if outside bounds & work with units
- VSC dev container fails to start
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oed.