react-notification-system and react about oed HOT 5 CLOSED

If react-notification-system is not actively maintained or does not have a compatible version for React 16, consider exploring alternative notification packages. There are several other notification libraries available for React that might suit your needs and are more up-to-date with React's latest versions. Some popular options include {react-toastify}, {react-notifications}, and {react-sweet-alert}.

from oed.

It seems this has been fixed by e4ca15b

from oed.

I also stumbled upon this issue when developing #879, and fixed it with 5ce9935, but that is no longer needed since react-notification-system is no longer used

from oed.

Thanks to everyone who looked into this. It does appear that OED is not actively using react-notification-system. It seems that src/client/app/utils/notifications.ts is using react-toastify. Thus, I propose we remove it from the code base. Here are the items I know of:

• Uninstall from package.json and package-lock.json.
• Remove all the commented out code involving react-notification-system in code and comments.
• Make sure the comment in src/scripts/installOED.sh about the issue is cleaned up.
• Remove all references to NotificationSystem.
• Maybe something else :-)

The hope is this should be fairly straightforward to finish.

from oed.

As @hyperupcall noted, I removed react-notification-system in e4ca1. Looks like I forgot to remove the related types package. This was something I had done as part of the React and node update effort, and I never had the time to properly finish after the end of the semester.

from oed.