Comments (13)
I like it.
from cogutil.
PRs #120 and opencog/atomspace#1832 fixed issue for opencog/cogutil and opencog/atomspace.
Repositories left:
- opencog/opencog
- opencog/moses
- opencog/benchmark
from cogutil.
- opencog/as-moses
as well.
from cogutil.
- opencog/agi-bio
as well
from cogutil.
I'm sort-of changing my mind as to whether I like it or not. I see what's good about the proposal, and I like that -- it moves all similar files to one central location. But there's also bad things about this: the files move to somewhere far away from the users of the files. It makes sense if there are multiple users, and one provider. But for many of these files, there is only one user (and there will only ever be one user) and so increasing the distance between user and provider does not seem like a good idea.
from cogutil.
Hi @linas, one argument I see is that when one is going to add new Find*.cmake tool he or she doesn't need search all repos and check if it is already here. Ideally these files should be a part of 3rd party library itself and it is not a part of code which uses it. So my idea was to move this files into utility library to allow using them from all other project if it is needed. cmake-data
Ubuntu package does the same thing. It provides Find*.cmake scripts for third party libraries (SDL for instance).
from cogutil.
In addition according #121 (comment) remove files: FindGSL.cmake, FindIODBC.cmake, FindLibMemCached.cmake, FindSDL_gfx.cmake
from cogutil.
I just run dpkg -L cmake-data | grep -E "/Find(.)+.cmake"
on ubuntu 14.04, for cmake version 2.8.12.2, and it seems we might not need some of the Find*.cmakes, eg protobuf, cxxtest
from cogutil.
@amebel, we can check this, there is a probability that custom Find*.cmake
files have some extra functionality. And may be some other non-Ubuntu users doesn't have similar package. But in general I agree that it is better to stick to standard Find*.cmake
utils.
from cogutil.
@vsbogd OK
from cogutil.
Is this done? See also issue #126
from cogutil.
Only opencog/benchmark repo is still not migrated to the new cmake Find* scripts. All other repos are migrated.
from cogutil.
closing. benchmark is migrated
from cogutil.
Related Issues (20)
- MacOS: Some tests are failing HOT 9
- minimize/avoid using boost in cogutil HOT 6
- build failure HOT 1
- Build errors: `not declared in this scope` HOT 1
- Loggers pointing to the same file step on each other HOT 1
- Find* cmake files installation path variable HOT 4
- libcogutil.so installed in incorrect location.
- OSX build error: "/etc/os-release" does not exist HOT 17
- Refactor get_python_lib from AtomSpace/OpenCog into CMAKE macro
- Upgrade to C++17? HOT 16
- Wrong interaction between stdout flag of different loggers HOT 3
- OC_OMP support is incorrect. HOT 2
- Breakage with Binutils 2.34 HOT 3
- Breakage with Binutils 2.35 (or maybe 2.34?) HOT 3
- GCC version 6 is not enough to build Atomspace, at least 7 or later is required HOT 4
- Unknown CMake command "add_compile_definitions". HOT 4
- Crash in logger during shutdown. HOT 1
- Failed to opam install cogutil HOT 4
- OSX build CMake error HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cogutil.