Organise OpenCog .cmake files about cogutil HOT 13 CLOSED

I like it.

from cogutil.

PRs #120 and opencog/atomspace#1832 fixed issue for opencog/cogutil and opencog/atomspace.
Repositories left:

• opencog/opencog
• opencog/moses
• opencog/benchmark

from cogutil.

• opencog/as-moses

as well.

from cogutil.

• opencog/agi-bio

as well

from cogutil.

I'm sort-of changing my mind as to whether I like it or not. I see what's good about the proposal, and I like that -- it moves all similar files to one central location. But there's also bad things about this: the files move to somewhere far away from the users of the files. It makes sense if there are multiple users, and one provider. But for many of these files, there is only one user (and there will only ever be one user) and so increasing the distance between user and provider does not seem like a good idea.

from cogutil.

Hi @linas, one argument I see is that when one is going to add new Find*.cmake tool he or she doesn't need search all repos and check if it is already here. Ideally these files should be a part of 3rd party library itself and it is not a part of code which uses it. So my idea was to move this files into utility library to allow using them from all other project if it is needed. cmake-data Ubuntu package does the same thing. It provides Find*.cmake scripts for third party libraries (SDL for instance).

from cogutil.

In addition according #121 (comment) remove files: FindGSL.cmake, FindIODBC.cmake, FindLibMemCached.cmake, FindSDL_gfx.cmake

from cogutil.

I just run dpkg -L cmake-data | grep -E "/Find(.)+.cmake" on ubuntu 14.04, for cmake version 2.8.12.2, and it seems we might not need some of the Find*.cmakes, eg protobuf, cxxtest

from cogutil.

@amebel, we can check this, there is a probability that custom Find*.cmake files have some extra functionality. And may be some other non-Ubuntu users doesn't have similar package. But in general I agree that it is better to stick to standard Find*.cmake utils.

from cogutil.

@vsbogd OK

from cogutil.

Is this done? See also issue #126

from cogutil.

Only opencog/benchmark repo is still not migrated to the new cmake Find* scripts. All other repos are migrated.

from cogutil.

closing. benchmark is migrated

from cogutil.