Return Shape as GeoJSON instead of String about uk-pv-national-gsp-api HOT 4 CLOSED

hmmm, im not quite sure how to do that.

I have a 'geoDataFrame' and i use to_json to put it to a json object.

Admittedly, all respsonse need response.json() to get the object.

Is json normally a string, but just the string is ~ like a dictionary - https://www.w3schools.com/python/python_json.asp

from uk-pv-national-gsp-api.

I just had another look.

So currently the endpoint for the GSP shapes returns this:

"{\"key\": \"value\"}"

But typically, with REST APIs, it would be good to return the JSON directly, instead of the string escaped version, ie

{"key": "value"}

geopandas.GeoDataFrame.to_json seems to return the JSON as string, as per the docs. I'd suggest that instead we try to return the dict directly, ie

to_json() -> to_dict()

https://github.com/openclimatefix/nowcasting_api/blob/96d8e46608e4ac9edcfea38918165ea41e43f3da/src/main.py#L92

According to FastAPIs docs, they would convert that dict into JSON automatically.

I wasn't able to get the API running locally, so I couldn't try it myself yet.

from uk-pv-national-gsp-api.

Cool ill do this - thanks for looking into this @flowirtz.

Im interested what error you got when you ran it locally?

from uk-pv-national-gsp-api.

Fantastic, thanks so much, Peter! I don't remember anymore tbh, but I'll try running it again later this week and debug together with you :)

from uk-pv-national-gsp-api.