CSS problem about alumnis HOT 10 CLOSED

why not define a max/min height for "project-item "class.

.project-item {
...
    min-height: 500px;
    max-height: 500px;
}

For contained "image-wrapper" something like a defined height and an auto width.

.image-wrapper {
   ...
    max-height: 300px;
    width: 100%;

.img-responsive {
    ...
    max-width: 100%;
    height: 200px;
    width: auto;

}

For the "project-description" class an overflow: scroll and a max-height

.project-description {
...
    max-height: 100px;
    overflow: auto;

}

It should look like this:

from alumnis.

It's an idea but the problem is that it would not be responsive and that would be a bigger problem.
I think it could be better to simply wrap columns into rows, like the official Bootstrap documentation indicates.
We should close the row and add a new one each 3 columns.
Do you want to give it a try? :)

from alumnis.

Ok Céline i just made a new PR to solve that on index and student pages :-)
#625

from alumnis.

Hello @celine-m-s,
As you asked me, i gave it a try !
Can you tell me what do you think about my PR #625 please ?
Thank you. :-)

from alumnis.

Greaaaaaat!
I just answered it. I think you are on the right path towards the solution! But maybe we could write less code adding a condition directly on the loop. Can you tell me if it works?

from alumnis.

Thank you for the review.
As you asked , i made the changes. It works like a charm and makes template more readable.
I Just update my PR. Travis checks are OK.

from alumnis.

That's perfect! I just merged your PR. Many thanks for your contribution!

from alumnis.

it was a pleasure and also my first real contribution!
Thank you for your help.

from alumnis.

;-)
There is another open issue if you're feeling bored! :-D

from alumnis.

I just make another PR #629 to replace empty students pictures with a generic one (OC svg). Nothing to do with the opened issue but i think it make the index page looking better. ; )
What do you think about that ?

I have to go back to my work but if i'm reading the OC cours about bootstrap.I have see how pagination is working and maybe i will try to solve opened issue in the next days if nobody tried before me.

from alumnis.