Code Monkey home page Code Monkey logo

Comments (5)

sjmudd avatar sjmudd commented on May 15, 2024

I also notice there is a IsCandidate field in Instance so these values seem to overlap. Or is there a requirement to set both settings to get the required behaviour?

I've just assumed that setting the PromotionRule would be good enough but perhaps that is not the case. This would require me to additionally do bulk changes to IsCandidate to ensure that orchestrator picks up all relevant promotion rules for the different slaves so seems to be more work.

Hence clarification of behaviour and expected configuration would be good.

from orchestrator.

sjmudd avatar sjmudd commented on May 15, 2024

Note: as a work around for my specific current usage I could do something like this:

  • modify go/inst/instance_dao.go RegisterCandidateInstance to set IsCandidate = true IF PromotionRule is must or prefer. That change is easy and while it doesn't resolve the must_not issue it does help and should be reasonably straightforward to implement.

However, please let me know if my understanding of intended usage of the current settings is valid or not.

from orchestrator.

sjmudd avatar sjmudd commented on May 15, 2024

So partial workaround implemented. Please consider accepting this if appropriate while a better solution is determined.

from orchestrator.

shlomi-noach avatar shlomi-noach commented on May 15, 2024

This is where IsCandidate gets to consider (or, rather, exclude) must_not servers: https://github.com/github/orchestrator/blob/92b5c7c093a2803cd8a5e483d64d522a1a17aa55/go/inst/instance_dao.go#L810-L811

from orchestrator.

shlomi-noach avatar shlomi-noach commented on May 15, 2024

On further discussing this event in private, there is no operational issue, but with concerns about wording.

the topology was something like:

master
+ replica1
+ replica2
   + testingserver

testingserver was set as must_not.

replica2 failed. orchestrator detected DeadIntermediateMasterWithSingleSlaveFailingToConnect and relocated testingserver under master.

There is no error here. The server testingserver was not turned to be master or intermediate master of other replicas. Wording wise, it was more "salvaged" than "promoted".

There is no flaw of logic in this failover and it worked as expected.

Discussed with @sjmudd we will pursue improved wording, on a new issue.

from orchestrator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.