Comments (5)
I also notice there is a IsCandidate
field in Instance
so these values seem to overlap. Or is there a requirement to set both settings to get the required behaviour?
I've just assumed that setting the PromotionRule
would be good enough but perhaps that is not the case. This would require me to additionally do bulk changes to IsCandidate to ensure that orchestrator picks up all relevant promotion rules for the different slaves so seems to be more work.
Hence clarification of behaviour and expected configuration would be good.
from orchestrator.
Note: as a work around for my specific current usage I could do something like this:
- modify
go/inst/instance_dao.go
RegisterCandidateInstance
to setIsCandidate
=true
IF PromotionRule ismust
orprefer
. That change is easy and while it doesn't resolve themust_not
issue it does help and should be reasonably straightforward to implement.
However, please let me know if my understanding of intended usage of the current settings is valid or not.
from orchestrator.
So partial workaround implemented. Please consider accepting this if appropriate while a better solution is determined.
from orchestrator.
This is where IsCandidate
gets to consider (or, rather, exclude) must_not
servers: https://github.com/github/orchestrator/blob/92b5c7c093a2803cd8a5e483d64d522a1a17aa55/go/inst/instance_dao.go#L810-L811
from orchestrator.
On further discussing this event in private, there is no operational issue, but with concerns about wording.
the topology was something like:
master
+ replica1
+ replica2
+ testingserver
testingserver
was set as must_not
.
replica2
failed. orchestrator
detected DeadIntermediateMasterWithSingleSlaveFailingToConnect
and relocated testingserver
under master
.
There is no error here. The server testingserver
was not turned to be master or intermediate master of other replicas. Wording wise, it was more "salvaged" than "promoted".
There is no flaw of logic in this failover and it worked as expected.
Discussed with @sjmudd we will pursue improved wording, on a new issue.
from orchestrator.
Related Issues (20)
- Project dead? HOT 3
- DeadIntermediateMaster auto Recovery HOT 1
- Failure from hooks are not reflected on UI HOT 1
- Automated recovery invalid HOT 5
- Should set old master's read_only to false under DeadCoMaster failure
- Report IntermediateMaster errors under CoMaster deployment
- Set the old primary host read_only=0 if failover/switch over failed.
- Whether ORC provides APIs that enable/disable recovery for specific clusters? HOT 1
- Using Azure AD Authentication
- How to set autocommit for orchestrtor detection thread
- How do you perform system tests? HOT 1
- Improve logging of problems during db connection
- Orchestrator able to display topology but still reports as failure
- After the Mysql domain name connection is configured。If the orchestrator topology displays both ip addresses and domain names of the same backup database, how can I fix this problem
- Discovery doesn't discover in extremely simple setup HOT 4
- Does orchestrator's website :3000 has login account?
- Does anyone know why updates stopped? HOT 2
- add windows version
- Ptrhon API Token
- How to login with username and password through API ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orchestrator.