Comments (7)
Distros are able to mitigate most of the issues (e.g. provide good initial set of enabled instrumentations) with either of those approaches, but they still need to manually curate list of 'good' scopes for each library and have a default for the rest.
👍
In the Java agent distro we've more or less landed on: "instrumentations which produce INTERNAL spans should be off by default, except for scheduled job instrumentations (which produce top-level INTERNAL spans)"
In general, my opinion is that instrumentation should be turned on by default. Otherwise, users have a very hard time discovering what instrumentation would be available.
this could also be a bad experience if say Hibernate natively instrumented itself producing INTERNAL spans. maybe that's not something we need to solve though, as there would likely be pushback on Hibernate to make this kind of instrumentation opt-in (via their own mechanism?)
from opentelemetry-specification.
We still have the consistency problem - at least some of the languages (.NET, not sure if there are any others) do "everything off by default" #3877 (comment)
All languages I'm aware of do "everything off by default" if you're just using the plain OTel SDK (no distro or auto-instrumentation).
Obviously the situation is different when using a distro or auto-instrumentation. The .NET auto-instrumentation turns on a bunch of instrumentation libraries by default.
I'd agree there's a conceived inconsistency between languages where auto-instrumentation is the default use case (Java) and others where it isn't (.NET).
from opentelemetry-specification.
@lmolkova I suggest that we look into the ability to use file config syntax to disable instrumentation.
In general, my opinion is that instrumentation should be turned on by default. Otherwise, users have a very hard time discovering what instrumentation would be available.
from opentelemetry-specification.
maybe also related to #3205
from opentelemetry-specification.
I think we can only continue the journey of everything is on by default since we're already on it and changing it would be breaking anyway. But we can make it better with new features like verbosity.
We still have the consistency problem - at least some of the languages (.NET, not sure if there are any others) do "everything off by default" #3877 (comment)
from opentelemetry-specification.
All languages I'm aware of do "everything off by default" if you're just using the plain OTel SDK (no distro or auto-instrumentation).
I have a different understanding! All languages are on-by-default, and .NET is the exception with off-by-default, strictly from plain OTel SDK!
By "on-by-default", what I mean is - traces/metrics from every tracer/meter is automatically collected, without any particular user-action. In .NET, the Meter/TracerProvider must be explicitly configured with the list of Tracers/Meters to listen to.
For the below pseudo code, .NET requires the TracerProvider
be explicitly configured with AddSource("foo")
for the spans from this tracer to work. In other languages I have checked (C++, Rust, Python), there is no additional config required.
fooTracer = get-tracer("foo");
fooTracer.StartSpan("myspan");
from opentelemetry-specification.
I have a different understanding! All languages are on-by-default, and .NET is the exception with off-by-default, strictly from plain OTel SDK!
@cijothomas You're right. For languages besides .NET it is enough to install and initialize instrumentation libraries, without additional SDK configuration. For .NET, additional SDK configuration is needed besides installing and initializing instrumentation libraries (for example AddSource
or AddMeter
on the SDK).
I was looking at it more from a user than from an SDK point of view: they have to install instrumentation libraries to "turn on" certain instrumentations. However, also from the user point of view my statement doesn't hold true when one takes into account native instrumentation (instrumentation in the instrumented library itself) which is enabled by default.
from opentelemetry-specification.
Related Issues (20)
- Stable instrumentations can change produced telemetry for bugfixes HOT 1
- No limits for log record body HOT 4
- Add specs for proxy support in exporters HOT 3
- Logs: Allow the registered processor to be an independent pipeline HOT 15
- Project Tracking: Sampling HOT 1
- Log section of spec compliance matrix is inconsistent
- Environment variable to set metrics producers HOT 3
- No clear API defined for resource detector libraries HOT 4
- Use ABNF syntax instead of PCRE2 in file configuration env var substitution syntax
- Define unit change schema transformation rule HOT 1
- [Editorial] Inline Hugo front matter HOT 4
- Clarify `Attributes` instrument advisory parameter HOT 1
- Clarify breaking changes are allowed when there is a major version bump HOT 1
- Sampler API V2: What, Why, and How?
- Define the purpose of events in OpenTelemetry HOT 13
- Apply new stability definitions to this repo HOT 2
- DataPoint Flags are not mentioned in the Metrics Data Model HOT 2
- Adding a means to denote preference for Link vs Span in given Context HOT 8
- Add stdout/json OTLP protocol (instead of OTLP file exporter) HOT 8
- [Prometheus Compatibility] Reconsider 1 to ratio unit conversion
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-specification.