Add Elixir record structs to support tests and integrations about opentelemetry-erlang HOT 7 CLOSED

Closing this as a won't fix. Maybe a contrib package could be created if someone submitted it.

from opentelemetry-erlang.

Hm, why? I'd rather not have the record exposed to anyone. Creation of events should go through the function call: OpenTelemetry.event/2

from opentelemetry-erlang.

It is far safer to require use of the functions because events need a timestamp in the proper format and the internal structure could change.

oh right, I think the issue with making it fully private is the use in exporters...

from opentelemetry-erlang.

Yeah, that's where the code above came from :).

Even if we do keep records private, our users will inevitably reverse engineer them when they need to. If we make breaking changes that cause problems, no amount of “yeah, but” will zero out the reputation damage. We're better off documenting our intended stability and version numbering strategy, I reckon.

from opentelemetry-erlang.

There may be functions to fetch information out of such records, so if the user want some informations if they need to, without reverse engineering the record itself. Of course if there is no such functions yet.

from opentelemetry-erlang.

That's Record.defrecord/3's job, yeah. We could switch defrecordp above to defrecord to expose an event macro for which event(e, :system_time_nano) would return just that field, but it'd also expose a write API, hence my habit of providing from/1 giving a struct.

from opentelemetry-erlang.

Here's a fun corner case: getting Span out of deps/opentelemetry/include/otel_span.hrl. For the first time, I'm tempted to drag all the machinery I'd use for testing integrations into its own package.

from opentelemetry-erlang.