Comments (6)
tsloughter
commented on June 4, 2024
Argh, yes, we should remove this check.
from opentelemetry-erlang.
ioolkos
commented on June 4, 2024
Ok, something like this then:
-spec set_default_tracer(tracer()) -> boolean().
set_default_tracer(Tracer) ->
persistent_term:put({?MODULE, default_tracer}, Tracer).
-spec set_tracer(atom(), tracer()) -> boolean().
set_tracer(Name, Tracer) ->
persistent_term:put({?MODULE, Name}, Tracer).
-spec set_default_meter(meter()) -> boolean().
set_default_meter(Meter) ->
persistent_term:put({?MODULE, default_meter}, Meter).
-spec set_meter(atom(), meter()) -> boolean().
set_meter(Name, Meter) ->
persistent_term:put({?MODULE, Name}, Meter).from opentelemetry-erlang.
tsloughter
commented on June 4, 2024
It can still check if the module exists, even if it doesn't depend on the tracer behaviour being there.
from opentelemetry-erlang.
tsloughter
commented on June 4, 2024
I added a fix here #137
from opentelemetry-erlang.
ioolkos
commented on June 4, 2024
Thanks! I'll test it.
from opentelemetry-erlang.
ioolkos
commented on June 4, 2024
Behaves as expected now. Thanks.
from opentelemetry-erlang.
Related Issues (20)
- Support for Metrics Producer HOT 1
- Support for Metric Exemplars
- Add new add_link function
- Rename view_aggregation to stream HOT 1
- service.instance.id is sent as an integer, not as a string in protobuf messages HOT 1
- logging a keyword list is incorrectly detected as a string HOT 1
- Injecting and extracting traceparent for distributed tracing HOT 8
- Update exemplar random seleection
- Metric Filters
- Metric cardinality limits
- Metric sync gauge
- Metrics: Investigate using metrics key with bucket index for histograms
- Exponential histogram
- Use a sorted list for attributes in metrics HOT 1
- Wrong seen count in exemplars test HOT 1
- broken typespec for otel_span:start_opts HOT 1
- Histogram metric with cumulative temporality HOT 19
- Histogram transient test failure
- Flapping exemplars test failure
- Codecov always fail
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from opentelemetry-erlang.