Comments (8)
We can just go with removing the line @Asin-Junior-Honore
from landing-page.
I've assigned the issue to you @Asin-Junior-Honore. Thanks for tackling this!
from landing-page.
Hey π
@nickytonline , @bdougie I have just finish resolving the issue kindly review my pr thanksπ
No need to ping us directly. The whole team gets GitHub notifications. π
from landing-page.
It happens on larger screens too. Removing this line fixes it, so maybe the conditional check isn't quite right.
from landing-page.
@nickytonline I would love to fix this pleaseπ§βπ»
from landing-page.
@Asin-Junior-Honore, you're welcome to work on it. I'm just not positive if the line I mentioned should show the subscribe component in certain pages, or if it's included, does it double the subscribe form everywhere.
Deferring to @BekahHW or @chhristopher to see where the standalone subscribe form should be or can we just remove the line I mentioned completely?
from landing-page.
Alright then I guess I would just wait for @BekahHW or @chhristopher to give a precise response before I proceed
from landing-page.
Hey π
@nickytonline , @bdougie I have just finish resolving the issue kindly review my pr thanksπ
from landing-page.
Related Issues (20)
- Bug: broken links in the changelog page HOT 1
- Add new product hunt badge
- Feature: create subdirectory for docs
- Bug: optimize teams page
- feat: Add newsletter as a subdirectory
- Feature: Add intro course as a subdirectory
- Add StarSearch Share to Changelog HOT 3
- Add Contributor Confidence to Changelog HOT 1
- Update sitemap
- Add Missing Canonical Tags HOT 2
- Feature: Add breadcrumbs to navigation HOT 2
- Feature: Create a consumer-facing sitemap
- Add Reddit share button to blog HOT 2
- Add sitemaps from docs and community-resources to robots.txt.
- Update About Page copy
- Update links based on redirects and remove discord
- Bug: Move off of abandoned `sanity-codegen`
- Add better filtering for adding a GH org to changelog HOT 1
- Bug: Move off abandoned `sanity-plugin-asset-source-ogimage` package
- Bug: Sanity Studio not working
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from landing-page.