Code Monkey home page Code Monkey logo

Comments (9)

CBID2 avatar CBID2 commented on July 20, 2024 1

Hmmm, if we replace the hamburger menu with a close button, where should we put the other tabs @wasimapinjari? 🤔

🤔 Sorry please what other tabs? I guess what he trying to say is we'll retain the hamburger button but there will be a toggle close button like the example he showed in the video

So when you click on the hamburger it'll show the close hamburger button

Ohh I get what you mean now @dev-phantom. Hey @wasimapinjari, I rewatched your clip, and I agree with @bdougie. It'll be a great idea.

from landing-page.

dev-phantom avatar dev-phantom commented on July 20, 2024

I guess that design was intensional and also this should be a feature request not a bug

from landing-page.

wasimapinjari avatar wasimapinjari commented on July 20, 2024

I was initially going to make it a feature request but then I thought having no close button really feels like a bug to me because I rarely come across such websites that don't implement it 😅

from landing-page.

dev-phantom avatar dev-phantom commented on July 20, 2024

@bdougie should I add a toggle close button or that is how the design is meant to be?

from landing-page.

CBID2 avatar CBID2 commented on July 20, 2024

Hmmm, if we replace the hamburger menu with a close button, where should we put the other tabs @wasimapinjari? 🤔

from landing-page.

dev-phantom avatar dev-phantom commented on July 20, 2024

Hmmm, if we replace the hamburger menu with a close button, where should we put the other tabs @wasimapinjari? 🤔

🤔
Sorry please what other tabs?
I guess what he trying to say is we'll retain the hamburger button but there will be a toggle close button like the example he showed in the video

So when you click on the hamburger it'll show the close hamburger button

from landing-page.

bdougie avatar bdougie commented on July 20, 2024

@dev-phantom your solution sounds ideal

from landing-page.

dev-phantom avatar dev-phantom commented on July 20, 2024

.take

from landing-page.

github-actions avatar github-actions commented on July 20, 2024

Thanks for taking this on! If you have not already, join the conversation in our Discord

from landing-page.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.