Code Monkey home page Code Monkey logo

Comments (13)

bdougie avatar bdougie commented on June 2, 2024 4

We may be ready to start adding CI/build things now that the extension works. @diivi I am assigning it to you, but we can chat through it on Monday.

  1. Copy portions of the hot repo CI - https://github.com/open-sauced/hot/blob/beta/.github/workflows/release.yml
  2. Build should include zipping the dist output.
  3. zip should get added to GitHub Packages.

If you haven't done this, that is fine. We are going to keep it simple and @0-vortex can also answer questions as well.

from ai.

bdougie avatar bdougie commented on June 2, 2024 2

Sorry, let's wait on this and get the extension functional first @Anush008. Actions are disabled on this repo for now.

from ai.

0-vortex avatar 0-vortex commented on June 2, 2024 2

@0-vortex I tried copying the config in my fork, I am getting the following error when I run the workflow:

image

My workflow file: https://github.com/diivi/browser-extensions/actions/runs/4791902136/workflow

It's probably because opensauced/releases uses node v16, but it works fine with other repos.

Can you suggest a solution for this?

You are trying to run the build and release step at the same time, that's why you get conflicts, the release action is running dockerized expecting to be in a sandbox (this is in order for us to not install devDependencies like semantic-release npm packages and attach a config to every repo)

Like @takanome-dev suggested in #16 (comment) a copy paste of that file with minor changes is what it should look like 🍕

from ai.

0-vortex avatar 0-vortex commented on June 2, 2024 1

I was able to get this working, just one more thing, how do I add the dist folder as a zip file to the release assets? Here's the new workflow file that I tried doing this with - https://github.com/diivi/browser-extensions/actions/runs/4812113139/workflow

the steps here are correct: https://github.com/diivi/browser-extensions/actions/runs/4812113139/workflow#L67-L77

however, the automatic archiving from semantic-release happening here: https://github.com/open-sauced/release/blob/main/release.config.js#L141-L149

is actually handled by npm pack and the configuration in package.json - https://docs.npmjs.com/cli/v9/commands/npm-pack?v=true should be helpful in debugging this

These steps here are duplicating the release flow: https://github.com/diivi/browser-extensions/actions/runs/4812113139/workflow#L79-L88 suggest removing those completely 🍕

from ai.

bdougie avatar bdougie commented on June 2, 2024 1

tgz is fine. Since there will not be an automated process to deploy to production, we just need a version uploaded. Type is not relevant.

from ai.

0-vortex avatar 0-vortex commented on June 2, 2024

We may be ready to start adding CI/build things now that the extension works. @diivi I am assigning it to you, but we can chat through it on Monday.

  1. Copy portions of the hot repo CI - https://github.com/open-sauced/hot/blob/beta/.github/workflows/release.yml
  2. Build should include zipping the dist output.
  3. zip should get added to GitHub Packages.

If you haven't done this, that is fine. We are going to keep it simple and @0-vortex can also answer questions as well.

Ready to help! ❤️

from ai.

diivi avatar diivi commented on June 2, 2024

@0-vortex I tried copying the config in my fork, I am getting the following error when I run the workflow:

image

My workflow file:
https://github.com/diivi/browser-extensions/actions/runs/4791902136/workflow

It's probably because opensauced/releases uses node v16, but it works fine with other repos.

Can you suggest a solution for this?

from ai.

takanome-dev avatar takanome-dev commented on June 2, 2024

It's probably because opensauced/releases uses node v16, but it works fine with other repos.

Can you provide links to the repos you are referring to?
The hot and insights repos use node@16 for the release action.

Can you suggest a solution for this?

Did you try to build the project with node@16, upload it using actions/upload-artifact and download it with actions/download-artifact before using the release action?
That's how it's done here

from ai.

diivi avatar diivi commented on June 2, 2024

I was able to get this working, just one more thing, how do I add the dist folder as a zip file to the release assets? Here's the new workflow file that I tried doing this with - https://github.com/diivi/browser-extensions/actions/runs/4812113139/workflow

from ai.

bdougie avatar bdougie commented on June 2, 2024

How about we create a beta branch and make that default and test the releases by doing the above changes and testing it out. Alternatively, we can test it in your fork @diivi

from ai.

diivi avatar diivi commented on June 2, 2024

@0-vortex wouldn't the steps you mentioned work only with tgz archives?

@bdougie wanted just a .zip archive to be attached to releases so he could upload it directly to the chrome extension store.

from ai.

github-actions avatar github-actions commented on June 2, 2024

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from ai.

github-actions avatar github-actions commented on June 2, 2024

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from ai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.