fix psp templates about gatekeeper-library HOT 4 CLOSED

Hi, thanks for the contribution!

I have a couple of questions:

1. What is the difficulty with creating a PR? Is there anything we can do help with that? It's much easier to review and comment on code when we can read the diff.

2. What is the bug you're looking to fix? Taking a look at the diff it seems like you are removing an explicit check for field existence, which seems to leave the policy vulnerable to approving pods with missing security contexts. Is there something I'm missing?

from gatekeeper-library.

Closing, please re-open if there is more follow up.

from gatekeeper-library.

@maxsmythe I am unable to push a pr..

 git push --set-upstream origin update-policies
ERROR: Permission to open-policy-agent/gatekeeper.git denied to jonny-wg2.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Essentially, the reason is to indeed remove the check for the field of securityContext because many pods will not have yet these policies will then fail.

from gatekeeper-library.

Ah, WRT the PR, for GitHub what you do is fork the Gatekeeper repository, then push your PR to a branch on your personal fork, then the shell will print out a link for creating a PR on GitHub.

However, I think we want to require these fields exist, as without them the required security trait (e.g. privilege escalation is not allowed), is missing. Or am I missing something?

@ritazh it also looks like K8sPSPAllowPrivilegeEscalationContainer is misnamed... shouldn't it be K8sPSPDisallowPrivilegeEscalationContainer as we are denying containers with privilege escalation?

from gatekeeper-library.