Code Monkey home page Code Monkey logo

Comments (22)

giswqs avatar giswqs commented on August 17, 2024 2

openmim and model-index have been published on conda-forge.
https://anaconda.org/conda-forge/openmim

@zhouzaida Would you be willing to be listed as a maintainer of the package on conda-forge?
https://github.com/conda-forge/openmim-feedstock

from mim.

giswqs avatar giswqs commented on August 17, 2024 1

It seems model-index is not heavily used by openmin. The load() function is used once, and ModelIndex is used twice. I am not sure if it makes sense to make model-index an optional package for openmin since model-index is not actively maintained. Basically, put the modelindex import statement within the function rather than at the top-level import. In that way, it does not need to be listed as a dependency for PyPI. This can be a backup plan in case we can't get modelindex on conda-forge.

@zhouzaida Is it something you would consider?

https://github.com/open-mmlab/mim/blob/main/mim/commands/search.py#L295

from modelindex.load_model_index import load
from modelindex.models.ModelIndex import ModelIndex

from mim.

giswqs avatar giswqs commented on August 17, 2024 1

@zhouzaida Understood. Let's get model-index published first.

from mim.

arturdaraujo avatar arturdaraujo commented on August 17, 2024

I fully agree! If any help is needed I'm here. Just a reminder that you only need to publish once, because the updates are automatically done. It's worth entering the conda-forge ecosystem.

from mim.

zhouzaida avatar zhouzaida commented on August 17, 2024

Hi @giswqs and @arturdaraujo, thanks for your suggestion. It sounds good and we will make openmim available ASAP.

from mim.

arturdaraujo avatar arturdaraujo commented on August 17, 2024

We don't mind publishing and we can add you as maintainer. @giswqs is an experienced conda-forge publisher

from mim.

giswqs avatar giswqs commented on August 17, 2024

I just checked. openmin requires model-index, so will need to make model-index available first.

image

from mim.

giswqs avatar giswqs commented on August 17, 2024

@zhouzaida is model-index an absolute requirement for openmim? Can it be made as an optional package?

from mim.

arturdaraujo avatar arturdaraujo commented on August 17, 2024

I think this is the one
pypi: https://pypi.org/project/model-index/
github: https://github.com/paperswithcode/model-index

from mim.

zhouzaida avatar zhouzaida commented on August 17, 2024

@zhouzaida is model-index an absolute requirement for openmim? Can it be made as an optional package?

model-index is a required package. Runtime requirements can be found at https://github.com/open-mmlab/mim/blob/main/requirements/install.txt

from mim.

arturdaraujo avatar arturdaraujo commented on August 17, 2024

Let's publish model-index

from mim.

giswqs avatar giswqs commented on August 17, 2024

And model-index requires modelindex, so we need modelindex as well. https://pypi.org/project/modelindex/

image

from mim.

zhouzaida avatar zhouzaida commented on August 17, 2024

modelindex is an alias for the model-index library. More details at https://pypi.org/project/modelindex/.

from mim.

giswqs avatar giswqs commented on August 17, 2024

It is indeed a rabbit hole. And modelindex recipe fails to create. We might be stuck.

image

from mim.

arturdaraujo avatar arturdaraujo commented on August 17, 2024

modelindex has no github page it seems

from mim.

arturdaraujo avatar arturdaraujo commented on August 17, 2024

What a useless thing is "alias package". Does it make sense to simply remove modelindex from the recipe? I think we can talk to the devs from conda-forge

from mim.

arturdaraujo avatar arturdaraujo commented on August 17, 2024

Another alternative would be to ask model-index maintainers to remove modelindex, but they don't see to be active for a while

from mim.

giswqs avatar giswqs commented on August 17, 2024

I agree with you. What a weird way to list an alias package of itself as a dependency, but that alias package is not being maintained.

from mim.

arturdaraujo avatar arturdaraujo commented on August 17, 2024

This looks good! @zhouzaida

from mim.

zhouzaida avatar zhouzaida commented on August 17, 2024

It seems model-index is not heavily used by openmin. The load() function is used once, and ModelIndex is used twice. I am not sure if it makes sense to make model-index an optional package for openmin since model-index is not actively maintained. Basically, put the modelindex import statement within the function rather than at the top-level import. In that way, it does not need to be listed as a dependency for PyPI. This can be a backup plan in case we can't get modelindex on conda-forge.

@zhouzaida Is it something you would consider?

https://github.com/open-mmlab/mim/blob/main/mim/commands/search.py#L295

from modelindex.load_model_index import load
from modelindex.models.ModelIndex import ModelIndex

This command mim search is used frequently and it would be user-friendly to install model-index automatically when installing openmim.

from mim.

arturdaraujo avatar arturdaraujo commented on August 17, 2024

I'm also looking for alternatives that are up to date and maintained by a larger organization.

This one may work?

from mim.

zhouzaida avatar zhouzaida commented on August 17, 2024

openmim and model-index have been published on conda-forge. https://anaconda.org/conda-forge/openmim

@zhouzaida Would you be willing to be listed as a maintainer of the package on conda-forge? https://github.com/conda-forge/openmim-feedstock

Yes, I would. Thanks for your contributions.

from mim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.