[Question] `API.shutdown()` required in Go? about spec HOT 5 CLOSED

I am also fine with language-specific implementations to handle the shutdown (context VS shutdown method).

After going through the spec, I think we should keep the keyword MUST and redefine the requirement to align with providers. Example suggestion,

The API MUST define a mechanism to propagate shutdown request to active providers

Also, requirement section ...must call the respective shutdown function on the active provider mismatch with the provider shutdown requirement [1], which is using the keyword MAY (contradict with must call as the provider might skip this)

The provider MAY define a shutdown function.... [1]

Altogether, if we agree on this, then we should correct both API & Provider spec sections to align.

[1] - https://github.com/open-feature/spec/blob/main/specification/sections/02-providers.md#25-shutdown

from spec.

I think that's reasonable

from spec.

Both solution are fine for me, but from the provider point of view it is always a bit tricky to have specificity for one language. I would prefer to have the same pattern everywhere.

If we want to go with the context approach I think we need to be extra cautious to make it explicit in the documentation how we expect providers to handle this.

from spec.

I am also fine with language-specific implementations to handle the shutdown (context VS shutdown method).

After going through the spec, I think we should keep the keyword MUST and redefine the requirement to align with providers. Example suggestion,

The API MUST define a mechanism to propagate shutdown request to active providers

Also, requirement section ...must call the respective shutdown function on the active provider mismatch with the provider shutdown requirement [1], which is uses the keyword MAY (contradict with must call as the provider might skip this)

The provider MAY define a shutdown function.... [1]

Altogether, if we agree on this, then we should correct both API & Provider spec sections to align.

[1] - https://github.com/open-feature/spec/blob/main/specification/sections/02-providers.md#25-shutdown

I like this proposal.

from spec.

@toddbaert this can be closed now as you already merged #193

from spec.