Comments (1)
cupOJoseph
commented on June 1, 2024
ODSafeManager is the only thing that is allowed to the external mint function on Vault721.
The vault ID is incremented in the Safe Manager for simplicity, instead of the NFT mint function (which is the normal way to do it).
Theres no way to test this directly by calling the vault721 contract mint function, since any call not from the safe manager is rejected. Good.
Therefore the existing testing logic includes:
- only ODSafeManager can call the external mint function on the vault721 NFTs
- the ID of vaults is always incremented correctly before being passed to the mint function.
- it is not possible to duplicate vault IDs
- good job, Hunter
from od-contracts.
Related Issues (20)
- Scripts final cleanup
- Deployment, naming of "governor"
- BasicActions _getGeneratedDeltaDebt precision issue HOT 1
- Testing cheatcodes, CAH failures HOT 1
- Add PrankSwitch to Utils
- Fix failing NFV Renderer tests
- Increase fuzz rejects
- Fix ODGovernor Cancel Proposal Tests
- Export contracts as a package HOT 1
- Immediate debt increase HOT 1
- Gov script: Allow generating, simulating proposals without a private key
- Solidity Export Action debugging
- Gov script: flexible proposal
- add allowSAFE to basicActions protect safe function
- [Blocked] NFV SVG logo update
- Docs deployment
- Liquidation fee for highly over-collateralized debt HOT 1
- create a saviour HOT 1
- Deploy new BasicActions
- Solidity exporter solidity version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from od-contracts.