Code Monkey home page Code Monkey logo

Comments (8)

mchandler11 avatar mchandler11 commented on May 30, 2024

Also. If I try "merging symbols even if name doesn't match", the window appear. I hit "don't merge", and I get the wrong message. It should not have merged....
Screen Shot 2019-04-25 at 12 44 36 PM

from merge-duplicate-symbols.

oodesign avatar oodesign commented on May 30, 2024

Hi @mchandler11,

Sorry to hear that. Which Sketch version and plugin version are you using?

I'm afraid we're not able to reproduce it with our testing set, though.

May you send us a Sketch file with just the symbols that are causing the issue?
You may replace its real content by dummy rectangles, if you wish to. We only need the symbols and its names.

We'll also take a look at that wrong message when you cancel merge and let you know when it's solved.

Thanks!

from merge-duplicate-symbols.

mchandler11 avatar mchandler11 commented on May 30, 2024

Thanks, @oodesign.

The thing is, it's a giant design library file with over 450 symbols. I don't know where duplicates are, but I've included a file with just the icons.
DSL.sketch.zip

from merge-duplicate-symbols.

oodesign avatar oodesign commented on May 30, 2024

Hi @mchandler11 !

We just released v4.0.4, that solves the messaging issue you addressed.

Thanks for taking some time to build that file for us to test, but sadly we still cannot reproduce the crashes you are describing (symbols merge properly, merging selected symbols merge properly, ...)

Is there any way that you can figure out which symbols led the plugin to crash when applied to your file? If you are able to do so, can you paste those same symbols to a new file, run the plugin there, and check if it also crashes?

If so, may you please send us that file with just the symbols that are causing the issue?
Again, you may replace its real content by dummy rectangles, if you wish to. We only need the symbols and their names.

Apart, may I also ask you which Sketch version are you using?

Thanks!

from merge-duplicate-symbols.

mchandler11 avatar mchandler11 commented on May 30, 2024

Thank, @oodesign.

But, I don't have the bandwidth to go through 450+ symbols and investigate. For future reference, it would be helpful if you guys built a script log that I could just send to you.

Attached is a file with just the symbols. Sketch v.54.1
ODSM.zip

from merge-duplicate-symbols.

mchandler11 avatar mchandler11 commented on May 30, 2024

Also, I know there are symbols to merge. Here is what I got just now, before the plugin crashed.
Screen Shot 2019-04-26 at 8 18 26 AM

from merge-duplicate-symbols.

oodesign avatar oodesign commented on May 30, 2024

Hi @mchandler11 ,

We can't see any duplicated symbols in your file, and MergeSelected (or even renaming some to match) and launching MergeDuplicate worked for us...

So here's what I'd suggest: we've built a verbose release (with logs). May you install this version of the plugin, and send us back the logs? You may do that by:

  1. Uninstall your current version of the "Merge Duplicate Symbols" plugin.
  2. Head to the release that traces logs, and download the Source Code.zip file
  3. Unzip it, and double-click on the MergeDuplicateSymbols.sketchplugin to install it.
  4. Run it as always on your Sketch design file.
  5. Head to ~/Library/Logs/com.bohemiancoding.sketch3/ (you may open a Terminal window, and type "cd ~/Library/Logs/com.bohemiancoding.sketch3/", and then type "open . ")
  6. Send us the Plugin Log.log file

If you wish to (if you don't like sending us the complete log file), you can delete the Plugin Log.log file prior to running the plugin. Sketch will create it again with just the MergeDuplicateSymbols plugin logs. Or you can send us just our plugin logs. They're easily traceable, because they all start with "MDS -- ".

Hope it helps.

Thanks!

from merge-duplicate-symbols.

oodesign avatar oodesign commented on May 30, 2024

Hi @mchandler11,

Did it get any better? Are you still experiencing these issues?

If so, that log would really help us out.
Let us know if there's anything else we can help with.

Thanks!

from merge-duplicate-symbols.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.