Comments (6)
I think we’re on the same page - just miscommunications on the coordinate system. i can work on this, it shouldn’t be a difficult change.
from ginkgo.
hey @grosser I agree that this would be much nicer. I think it's a bit tricky to do as it would entail parsing the AST tree to find the It
(or innermost Describe/Context
) that contains the line in question.
from ginkgo.
I was hoping there is some internal "list of locations" and we could walk that backwards until we find the first "location"
from ginkgo.
there is a data structure that contains all the ginkgo nodes and their locations. but there are edge cases:
Describe(“foo”, func() { //L1
It(“bar”, func() { //L2
…
})
It(“baz”, func() { //L3
…
})
})
the data structure has L1, L2, and L3 associated with he describe and the two Its. what should run if the user picks the line at L3-1? it’s in the describe, not either of the two its, so both its should run. but there’s no way to be sure since there can be arbitrary amounts of white space in between the two its.
perhaps it would be better to not worry about such edge cases and simply pick the closest node less than or equal to the provided line number and run that. that would be fairly simply to implement and might get us 90% of the way there.
from ginkgo.
L3-1 should be L3, since the logic is "something failed in this IT, so run this IT"
it should not be "the closest node" since an error above an IT can never be from that it, so logic is find next node to the top
from ginkgo.
Good luck, thx! :D
from ginkgo.
Related Issues (20)
- Run a single suite with N instances in parallel with different `BeforeSuite` Setup. HOT 3
- Feeding report back for focusing on failed test-cases HOT 1
- Junit report should have system-out HOT 1
- could not log in Eventually with fmt.Fprintf(GinkgoWriter) HOT 3
- Question: One Suite to rule them all HOT 2
- when using concurrency, a test case failure in a background go routine does not show which test case failed HOT 3
- Add cli flag to fail when no tests were run HOT 1
- `ginko -p 2` does not complain about having an extra argument
- How to integrate with xgo? HOT 7
- when watching, add ability to ignore hidden files (including tests!) HOT 5
- Report Portal and Gingko integration plugin
- Implement generic transformer decorator: ginkgo.ContextTransformer HOT 3
- why can't generate html report? HOT 1
- CLI: add long aliases for short options
- panic when passing context AND nil in a table Entry HOT 2
- Add support for Label Sets
- support outputting the time spent on each spec HOT 1
- [feature request] Test execution and reporting controller HOT 1
- [Documentation] Fix the wrong variable call in Section "Reporting Nodes - ReportBeforeSuite and ReportAfterSuite"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ginkgo.