Code Monkey home page Code Monkey logo

Comments (3)

only-cliches avatar only-cliches commented on May 21, 2024

Hello Te,

Thanks for looking into this!

The old query code was unnecessarily complex, the change made .where conditions much faster to check. I guess I forgot to clear out all the old code before I pushed the update. 😺

The current code/version passes the test in your fork already. CodePen

Can you you share with me a condition the current code fails under that your hotfix takes care of?

Best,
Scott

Edit: Ah, my apologies. Looks like I had pulled an older version into the CodePen, the newest version does fail on the test you provided.

There's another condition the current version fails on as well as your forked version, looks like I need to revisit the .where code and get it working for this test case also. CodePen

from nano-sql.

only-cliches avatar only-cliches commented on May 21, 2024

Just pushed version 1.4.4, reworked the .where() code and added a bunch of tests, let me know if the update didn't resolve everything.

from nano-sql.

only-cliches avatar only-cliches commented on May 21, 2024

Marking this as resolved since there hasn't been a response in a few days. Feel free to reopen if the issue comes up again or isn't resolved.

from nano-sql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.