Comments (7)
I believe it may be a bug where the reverse
option isn't correctly handled in all cases in the (msgpack_rpc)[https://neovim.io/doc/user/msgpack_rpc.html] API.
Are you using a custom colorscheme?
from oni.
This is old and no longer relevant with either solarized or default
from oni.
I'm using solarized dark truecolor, as you suggested (or maybe it was the vimR guys?) to use for gui. Other than that, I don't have any of my own customisations to the color
from oni.
The issue went away when I changed to wombat, I'll screw around with some settings and see if I can make it work.
from oni.
I tried Molokai with no tweaks, airline disabled, and it has issues. I can't actually take a good screenshot on mac because the meta key seems like it isn't handled
from oni.
Update: In a similar vein (pertaining to the colorschemes) certain errors ( use ! to force ) don't display or are highlighted improperly in the statusline. I think for solarized it might just be that the colors end up hiding the text, as molokai and wombat display them in wrong colors
from oni.
I was just taking a quick look at this... I believe I can reproduce it reliably like this:
The highlight for the second colorscheme is messed up - the background color is okay (it's yellow as it should be), but the foreground color is white instead of gray.
In Screen.ts
there is some code for handling this:
let foregroundColor = this._currentHighlight.foregroundColor ? this._currentHighlight.foregroundColor : this._foregroundColor
let backgroundColor = this._currentHighlight.backgroundColor ? this._currentHighlight.backgroundColor : this._backgroundColor
if (this._currentHighlight.reverse) {
const temp = foregroundColor
foregroundColor = backgroundColor
backgroundColor = temp
}
But reverse
isn't being set to true, and I don't see it being set.
There's also some interesting stuff happening in NeovimInstance.ts
where we directly process the message:
} else if (command === "highlight_set") {
const count = a.length
const highlightInfo = a[count - 1][0]
this.emit("action", Actions.setHighlight(
!!highlightInfo.bold,
!!highlightInfo.italic,
!!highlightInfo.reverse,
!!highlightInfo.underline,
!!highlightInfo.undercurl,
highlightInfo.foreground,
highlightInfo.background,
))
Particularly the a[count - 1]
- there were some cases we were getting multiple highlight calls, and only the last one seemed to be valid. This isn't hitting that case though.
It would be interesting to see how this behaves in other Neovim front-ends - there's a possibility that it is a Neovim bug.
from oni.
Related Issues (20)
- Unable to find csproj in golang project HOT 1
- (n)vi(m) in terminal within oni HOT 4
- Rebind regular hjkl motions for moving around globally in Oni's UI HOT 1
- Explorer does not show new files HOT 1
- Oni crashes on LSP call HOT 1
- replace nevim binary with newer
- how to use gopls with oni HOT 1
- Java autocompletion popup displaying wrong suggestion HOT 1
- Fuzzy Finder not working with WSL2 directory HOT 1
- How add support for new language with language server HOT 1
- how to display tabline in Oni? HOT 1
- Oni does not respect editor.quickOpen.execCommand HOT 1
- Adding support for Alt-Shift key bindings HOT 1
- Metals (Scala) language server integration works, but not auto-complete selection
- No file will open on Ubuntu 19.04 HOT 5
- UI freezes for ~10 seconds on :! external commands on Windows HOT 1
- Insiders link in Issue Template is 404'd
- 100%+ CPU spikes when typing colon commands HOT 1
- How to cycle through completions with tab? HOT 1
- Request: add .nix build script HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from oni.