tmsu merge A B : 'could not delete tag A: too many SQL variables' about tmsu HOT 3 CLOSED

Thanks for reporting. I'll check it out this evening. I imagine I've forgotten to commit a transaction.

from tmsu.

OK, tracked this down: issue was with the creation of a truly massive SQL statement when cleaning untagged files up after removal of the old tag.

TMSU always deletes files from the database when they become untagged. Orginally I had some code in place that would check every file whenever any untagging operation was performed but I made it more 'clever' a while back so that it only considered files that could possibly have been left untagged based upon what had just happened. However this 'clever' code was building a massive SQL statement from the set of potentially affected files.

I've changed it to, instead, iterate the set of files and delete each one individually if it is no longer tagged. I have made the same change to the similar code in where unused values are checked too.

However, it does still beg the question: why is it even checking that the files need to be deleted during a merge operation? The nature of the merge means that the same set of files will be tagged at the start and end so the untagged file check can be safely avoided.

from tmsu.

Changes in a405dce.

from tmsu.