Code Monkey home page Code Monkey logo

Comments (8)

onevcat avatar onevcat commented on May 17, 2024 1

There should be no concern for it. Kingfisher will remember the last set image url and ignore previous image loading, even if it is not yet finished.

from kingfisher.

onevcat avatar onevcat commented on May 17, 2024

Your code seems good to me except reseting the image once again when downloading successfully. The kf_setImageWithURL will set the image for you when everything goes OK.

May I know some more detail and context on how do you configure your cell? And you could check and the demo project in the repo as well, in which a collection view is used to show some images.

from kingfisher.

emmasuzuki avatar emmasuzuki commented on May 17, 2024

Thanks, you gave me a hint. The issue was the resetting. I guess my function did not maintain the imageView's references since it is a reused cell from collection view.

Here is a revised code:

imageView.kf_setImageWithURL(thumbnailUrl,
    placeholderImage: UIImage(named: "loading_image"),
    optionsInfo: nil,
    completionHandler: { [weak imageView] (image, error, cacheType, imageURL) -> () in
        if error != nil {
            imageView?.image = UIImage(named: "no_image")
        }
})

from kingfisher.

onevcat avatar onevcat commented on May 17, 2024

:)

from kingfisher.

Ankish avatar Ankish commented on May 17, 2024

@onevcat
imageView.kf_setImageWithURL(thumbnailUrl,
placeholderImage: UIImage(named: "loading_image"),
optionsInfo: nil,
completionHandler: { [weak imageView] (image, error, cacheType, imageURL) -> () in
if error != nil {
imageView?.image = UIImage(named: "no_image")
}
// for fast scrolling when the cell is reused and you might have 2 request for same cell on queue .should we also check if previous url is same as current one. To avoid showing wrong image on the cell till the correct one invokes and reloads the cell or is this handled. In the demo this is not handled.
Note I am using prepareForReuse() to set imageview.image = nil // does this take care of it.
Just curious before I put KF code in all over my project.
something like
if thumbnailUrl != imageURL{ // a completion for previous cell
imageView?.image = nil
}
})

from kingfisher.

HariNarayanan777 avatar HariNarayanan777 commented on May 17, 2024

Here what is the name of the image "no_image" means which is downloaded from the server image or your placeholder image.
?????

from kingfisher.

HariNarayanan777 avatar HariNarayanan777 commented on May 17, 2024

And also i am getting error "Value of type 'UIImage?' has no member 'kf_setImageWithURL'" what the extension for the method.?
Please help me.

from kingfisher.

emmasuzuki avatar emmasuzuki commented on May 17, 2024

@HariNarayanan777 UIImage(named: "no_image") is local image. When an error occurs fetching the image from the url, I will replace the placeholder image ("loading_image") to "no_image" image.

And kf_setImageWithURL is an old API and also Kingfisher's API is on UIImageView. Not on UIImage.

I think you can try

imageView.kf.setImage(
    with: imageUrl,
    placeholder: UIImage(named:"some_placeholder_image"),
    options: nil,
    progressBlock: nil,
    completionHandler: { (image: Image?, error: NSError?, cache: CacheType, url: URL?) in
})

from kingfisher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.