Unable to handle some files on Windows about omnisharp-emacs HOT 8 CLOSED

Best guess: the file is too long. Perhaps Windows limits the length
of parameters to curl, which is sending the request.

Might be able to work around this with echo and piping (if possible on
Windows). If that doesn't work, write the contents to a file and make
curl read that somehow.

from omnisharp-emacs.

Occurred on files at 1173 lines and one about 800 LOC so far.
Truncating the file to a lower treshold seems to work around the
issue.

from omnisharp-emacs.

A quick search led me to this:
http://stackoverflow.com/questions/3205027/maximum-length-of-command-line-string

It states there indeed is a character limit in command line statements.

from omnisharp-emacs.

There seem to be viable alternatives built in curl:

http://stackoverflow.com/questions/3007253/send-post-xml-file-using-curl-command-line
http://stackoverflow.com/questions/6408904/how-to-send-post-request-with-data-specified-in-file-via-curl

I'm thinking, on Windows systems we could default to using that
switch to send a temporary file contents (the current buffer contents).

Note that the current buffer contents != current file contents as the
editor commonly contains changed data vs. the actual file.

from omnisharp-emacs.

Oh lord, yes - sorry, only just seen this issue. Command line limits on Windows are a pain. A couple of suggestions:

1. Always send your Win7 curl commands via a temp file. It's usually not much slower than using a command line anyway as the file is most likely cached in memory, and it keeps things simple and consistent.
2. Switch to using the emacs url library. I'm guessing you've already looked into this and rejected it for a good reason. :)

from omnisharp-emacs.

Point 1 is probably the route I'll take, yes. I had the idea of using
some kinds of temporary files but don't really know much about
the possibilities of them on Windows yet.

About point 2: I tried many different options in the beginning. You
might still be able to find them early in the commit history. All of
them had some problems. Some just hung randomly, and after
a lot of pain I just got fed up and switched to curl. :/

from omnisharp-emacs.

Just implemented a fix for this. Works very well. No noticeable
slowdown, even! :)

Looks like this is usable on Windows again.
Will push fix to master later on.

from omnisharp-emacs.

Merged to master: 32c8ec5

from omnisharp-emacs.