Use Groovy traits to better separate Omni RPCs from Bitcoin RPCs about omnij HOT 7 CLOSED

Note: There seems to be a bug in Groovy 2.4.0 that occurs when the following lines are enabled in BitcoinCLIAPI.groovy:

@SelfType(BitcoinClient)
@CompileStatic

I've filed bug GROOVY-7275 on Groovy JIRA.

I'm also seeing two issues in the current latest IntelliJ:

1. IntelliJ doesn't seem to recognize the @SelfType(BitcoinClient) annotation yet and as a result can't find the methods called from the superclass.
2. IntelliJ is complaining about default parameters with the message: "Default Initializers are not allowed in abstract methods"

from omnij.

Groovy bug GROOVY-7275 is fixed in Groovy 2.4.1 and bitcoin-spock has been updated, so it may be time to try this again.

Although I'm thinking that it might be better if the "CLI" clients just warp the standard Java clients, rather than extend them, so traits may be less necessary.

from omnij.

That's great to hear.

Point 2 seems to be an issue of IntelliJ, and using default values appears to work just fine, despite the error tag. Given there are quite a few methods that could be reduced and merged by using defaults, even though the error is a bit distracting.

from omnij.

I need to renew my IntelliJ subscription and upgrade to the latest version. If the IntelliJ problems continue, I'll report them as bugs.

from omnij.

I'm currently using an EAP build of the v14.1 community edition, where the issue is still present.

from omnij.

I noticed in the latest EAP release notes "Good Groovy code red - traits with Generic" (IDEA-134978), however the issue related to default initializer values ("Default Initializers are not allowed in abstract methods") is still unfixed.

from omnij.

This is complete, except for completing the CLI clients. I've opened Issue #64 for that work.

from omnij.